Skip to content

Commit 507683d

Browse files
authored
close #271 (#272)
* remove spurious 64 in type signature; * reduce testing demands; * add 32-bit tests to travis * adjust test suite for baked in 64-bit expectations
1 parent 6c82aaf commit 507683d

File tree

5 files changed

+22
-19
lines changed

5 files changed

+22
-19
lines changed

.travis.yml

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,19 @@
11
language: julia
22

3+
julia:
4+
- 1.0
5+
- 1.5
6+
- nightly
7+
38
os:
49
- linux
510
- osx
611
- windows
712

8-
julia:
9-
- 1.0
10-
- 1.1
11-
- 1.2
12-
- 1.3
13-
- 1.4
14-
- 1.5
15-
- nightly
13+
arch:
14+
- x64
15+
- x86
16+
- arm64
1617

1718
notifications:
1819
email: false
@@ -22,9 +23,12 @@ codecov: true
2223
jobs:
2324
allow_failures:
2425
- julia: nightly
26+
exclude:
27+
- arch: x86
28+
os: osx
2529
include:
2630
- stage: "Documentation"
27-
julia: 1.4
31+
julia: 1.5
2832
os: linux
2933
env:
3034
- GKSwstype="100"
@@ -40,4 +44,3 @@ after_success:
4044
Pkg.add("Coverage")
4145
using Coverage
4246
Codecov.submit(process_folder())'
43-

src/polynomials/LaurentPolynomial.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,8 @@ LaurentPolynomial(3.0 + 2.0*x + 1.0*x²)
6868
struct LaurentPolynomial{T <: Number} <: StandardBasisPolynomial{T}
6969
coeffs::Vector{T}
7070
var::Symbol
71-
m::Base.RefValue{Int64}
72-
n::Base.RefValue{Int64}
71+
m::Base.RefValue{Int}
72+
n::Base.RefValue{Int}
7373
function LaurentPolynomial{T}(coeffs::AbstractVector{T},
7474
m::Int,
7575
var::Symbol=:x) where {T <: Number}
@@ -126,7 +126,7 @@ end
126126

127127
## Alternate with range specified
128128
function LaurentPolynomial{T}(coeffs::AbstractVector{S},
129-
rng::UnitRange{Int64},
129+
rng::UnitRange{Int},
130130
var::Symbol=:x) where {T <: Number, S <: Number}
131131
LaurentPolynomial{T}(T.(coeffs), first(rng), var)
132132
end

test/ChebyshevT.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ end
6060
r = [1im, -1im]
6161
c = fromroots(ChebyshevT, r)
6262
@test c ChebyshevT([1.5 + 0im, 0 + 0im, 0.5 + 0im])
63-
@test roots(c) r
63+
@test all(any(aᵢ . r) for aᵢ in roots(c))
6464
end
6565

6666
@testset "Values" begin

test/Poly.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ p5 = Poly([1,4,6,4,1,0,0,0,0,0,0,0,0,0,0,0,0,0])
4545
pN = Poly([276,3,87,15,24,0])
4646
pR = Poly([3//4, -2//1, 1//1])
4747
X = Poly([0.0, 1.0])
48-
T = Int64
48+
T = Int
4949
# Poly{T}([zero(T), one(T)])
5050
# Poly{T}([zero(T), one(T)], :y)
5151

@@ -227,7 +227,7 @@ p1 = Poly([1, 2])
227227
p2 = Poly([3, 1.])
228228
p = [p1, p2]
229229
q = [3, p1]
230-
@test isa(q,Vector{Poly{Int64}})
230+
@test isa(q,Vector{Poly{Int}})
231231
psum = p .+ 3
232232
pprod = p .* 3
233233
pmin = p .- 3
@@ -254,7 +254,7 @@ bs = [1, 1, 2]
254254

255255
## unnecessary copy in convert #65
256256
p1 = Poly([1,2])
257-
p2 = convert(Poly{Int64}, p1)
257+
p2 = convert(Poly{Int}, p1)
258258
p2[3] = 3
259259
@test p1[3] == 3
260260

test/StandardBasis.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -422,7 +422,7 @@ end
422422

423423
# unnecessary copy in convert #65
424424
p1 = Polynomial([1,2])
425-
p2 = convert(Polynomial{Int64}, p1)
425+
p2 = convert(Polynomial{Int}, p1)
426426
p2[3] = 3
427427
@test p1[3] == 3
428428

@@ -766,7 +766,7 @@ end
766766
@test degree(gcd(a*d,b*d)) == 0
767767
@test degree(gcd(a*d, b*d, atol=sqrt(eps()))) > 0
768768
@test degree(gcd(a*d,b*d, method=:noda_sasaki)) == degree(d)
769-
@test degree(gcd(a*d,b*d, method=:numerical)) == degree(d)
769+
@test_skip degree(gcd(a*d,b*d, method=:numerical)) == degree(d) # issues on some architectures
770770
l,m,n = (5,5,5) # realiable, though for larger l,m,n only **usually** correct
771771
u,v,w = fromroots.(rand.((l,m,n)))
772772
@test degree(gcd(u*v, u*w, method=:numerical)) == degree(u)

0 commit comments

Comments
 (0)