fix more issues with sorting for roots

Author: mileslucas

src/common.jl

@@ -109,7 +109,8 @@ function roots(p::AbstractPolynomial{T}) where {T <: Number}
     comp = companion(chopped_trimmed)
     L = eigvals(rot180(comp))
     append!(L, zeros(eltype(L), n_trail))
-    return sort!(L, rev = true, by = real)
+    by = eltype(L) <: Complex ? norm : identity
+    return sort!(L, rev = true, by = by)
 end
 
 """

src/polynomials/ChebyshevT.jl

@@ -12,13 +12,13 @@ terms of the given variable `x`. `x` can be a character, symbol, or string.
 
 ```jldoctest
 julia> c = ChebyshevT([1, 0, 3, 4])
-ChebyshevT([1, 0, 2, 4])
+ChebyshevT([1, 0, 3, 4])
 
-julia> ChebyshevT([1, 2, 3], :s)
+julia> ChebyshevT([1, 2, 3, 0], :s)
 ChebyshevT([1, 2, 3])
 
 julia> one(ChebyshevT)
-ChebyshevT(1.0)
+ChebyshevT([1.0])
 
 julia> convert(Polynomial, c)
 Polynomial(-2 - 12*x + 6*x^2 + 16*x^3)

test/ChebyshevT.jl

@@ -58,10 +58,10 @@ end
     @test c == ChebyshevT([0, -0.25, 0, 0.25])
     @test roots(c) ≈ sort(r, rev = true)
 
-    r = [-1im, 1im]
+    r = [1im, -1im]
     c = fromroots(ChebyshevT, r)
     @test c ≈ ChebyshevT([1.5 + 0im, 0 + 0im, 0.5 + 0im])
-    @test roots(c) ≈ sort(r, by = real, rev = true)
+    @test roots(c) ≈ r
 end
 
 @testset "Values" begin