Skip to content

Commit caabda3

Browse files
committed
noda sasaki need v1.2+
1 parent 9a9ea43 commit caabda3

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/polynomials/standard-basis.jl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,8 @@ References:
173173
[1] M.-T. Noda and T. Sasaki. Approximate GCD and its application to ill-conditioned algebraic equations. J. Comput. Appl. Math., 38:335–351, 1991.
174174
175175
Author: Andreas Varga
176+
177+
Note: requires Julia `v1.2` or greater.
176178
"""
177179
function gcd_noda_sasaki(p::P, q::Q;
178180
atol::Real=zero(real(promote_type(T,S))),

test/StandardBasis.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -692,7 +692,7 @@ end
692692
d = P([0.5490673726445683, 0.15991109487875477]);
693693
@test degree(gcd(a*d,b*d)) == 0
694694
@test degree(gcd(a*d, b*d, atol=sqrt(eps()))) > 0
695-
@test degree(gcd(a*d,b*d, method=:noda_sasaki)) == degree(d)
695+
VERSION >= v"1.2.0" && @test degree(gcd(a*d,b*d, method=:noda_sasaki)) == degree(d)
696696
@test degree(gcd(a*d,b*d, method=:numerical)) == degree(d)
697697

698698
l,m,n = (5,5,5) # realiable, though for larger l,m,n only **usually** correct
@@ -705,7 +705,7 @@ end
705705
q = (x+10)*(x^9 + x^8/7 - 6//7)
706706

707707
@test degree(gcd(p,q)) == 0
708-
@test degree(gcd(p,q, method=:noda_sasaki)) == 1
708+
VERSION >= v"1.2.0" && (@test degree(gcd(p,q, method=:noda_sasaki)) == 1)
709709
@test degree(gcd(p,q, method=:numerical)) == 1
710710

711711
# more bits don't help Euclidean

0 commit comments

Comments
 (0)