Skip to content

Commit 2b02802

Browse files
Format .jl files [skip ci] (#473)
Co-authored-by: jverzani <[email protected]>
1 parent 6429733 commit 2b02802

File tree

4 files changed

+29
-32
lines changed

4 files changed

+29
-32
lines changed

src/DerivativeFree/sidi.jl

Lines changed: 21 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ end
3636

3737
function init_state(M::Sidi{k}, F::Callable_Function, x) where {k}
3838
x₀, x₁ = x₀x₁(x)
39-
fx₀, xs, fs = _init_sidi(F, (x₀, x₁), k)
40-
state = SidiState(xs[k], xs[k+1], fx₀, fs[1], xs, fs)
39+
fx₀, xs, fs = _init_sidi(F, (x₀, x₁), k)
40+
state = SidiState(xs[k], xs[k + 1], fx₀, fs[1], xs, fs)
4141
end
4242

4343
function update_state(
@@ -46,15 +46,14 @@ function update_state(
4646
o::SidiState{T,S},
4747
options,
4848
l=NullTracks(),
49-
) where {k, T, S}
50-
49+
) where {k,T,S}
5150
xs, fs = o.xs, o.fs
5251
fxn1 = o.fxn1
5352
_update_sidi!(F, xs, fs)
5453

5554
incfn(l)
5655
@reset o.xn0 = xs[k]
57-
@reset o.xn1 = xs[k+1]
56+
@reset o.xn1 = xs[k + 1]
5857
@reset o.fxn0 = o.fxn1
5958
@reset o.fxn1 = fs[1]
6059
@reset o.xs = xs
@@ -79,7 +78,7 @@ function _init_sidi(f, x, k)
7978
x₀ = first(x)
8079
fx₀ = f(x₀)
8180

82-
xs = Vector{typeof( x₀)}(undef, k+1)
81+
xs = Vector{typeof(x₀)}(undef, k+1)
8382
fs = Vector{typeof(fx₀)}(undef, k+1)
8483

8584
n = length(x)
@@ -93,64 +92,62 @@ function _init_sidi(f, x, k)
9392
fs[2] = (fx₀ - fs[1]) / (xs[1] - xs[2])
9493

9594
# build up diagonal by diagonal
96-
for j 3:(k+1)
95+
for j in 3:(k + 1)
9796
if j n # xⱼ was specified
9897
xⱼ = xs[j]
9998
else
100-
xⱼ₋₁ = xs[j-1]
101-
pk′ = evaluate_pk′(view(xs, 1:j-1), view(fs, 1:j-1))
99+
xⱼ₋₁ = xs[j - 1]
100+
pk′ = evaluate_pk′(view(xs, 1:(j - 1)), view(fs, 1:(j - 1)))
102101
xⱼ = xs[j] = xⱼ₋₁ - fs[1] / pk′
103102
end
104103
Δ = f(xⱼ)
105-
for i 2:j
106-
Δ₀ = fs[i-1]
107-
fs[i-1] = Δ
108-
Δ = (Δ₀ - Δ) / (xs[j-i+1] - xs[j])
104+
for i in 2:j
105+
Δ₀ = fs[i - 1]
106+
fs[i - 1] = Δ
107+
Δ = (Δ₀ - Δ) / (xs[j - i + 1] - xs[j])
109108
end
110109
fs[j] = Δ
111110
end
112111

113112
# return fx₀ for bookkeeping purposes
114113
fx₀, xs, fs
115-
116114
end
117115

118116
# update step: compute xn, fxn, update the xs,fs tableau
119117
function _update_sidi!(f, xs, fs)
120118
xₙ₋₁, fxₙ₋₁ = xs[end], fs[1]
121119
fn′ = evaluate_pk′(xs, fs)
122-
xn = xₙ₋₁ - fxₙ₋₁ / fn′
120+
xn = xₙ₋₁ - fxₙ₋₁ / fn′
123121
fxn = f(xn)
124122
update_tableau!(xn, fxn, xs, fs)
125123
end
126124

127125
# formula (10) in paper to evaluate derivative of interpolating polynomial
128126
function evaluate_pk′(xs1, fs1)
129-
δ = xs1[end] - xs1[end-1]
127+
δ = xs1[end] - xs1[end - 1]
130128
Σ = fs1[2]
131129
k = length(xs1)
132-
for i 3:k
130+
for i in 3:k
133131
Σ = Σ + fs1[i] * δ
134-
δ = δ * (xs1[end] - xs1[end-i+1])
132+
δ = δ * (xs1[end] - xs1[end - i + 1])
135133
end
136134
Σ
137135
end
138136

139-
140137
# update tableau's lower part
141138
# leaves [xn-k, xn-k+1, xn-k+2, ..., xn]
142139
# [fn, f(n-1,n), f(n-2, n-1, n), ..., f(n-k,n-k+1, ..., n)]
143140
function update_tableau!(xn, fxn, xs0, fs0)
144141
k = length(xs0)
145-
for i in 1:k-1
146-
xs0[i] = xs0[i+1]
142+
for i in 1:(k - 1)
143+
xs0[i] = xs0[i + 1]
147144
end
148145
xs0[end] = xn
149146
Δ = fxn
150147
for i in 2:k
151-
Δ₀ = fs0[i-1]
152-
fs0[i-1] = Δ
153-
Δ = (Δ₀ - Δ) / (xs0[end-i+1] - xn)
148+
Δ₀ = fs0[i - 1]
149+
fs0[i - 1] = Δ
150+
Δ = (Δ₀ - Δ) / (xs0[end - i + 1] - xn)
154151
end
155152
fs0[end] = Δ
156153
xs0, fs0

src/find_zero.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -319,9 +319,9 @@ function init(
319319
end
320320

321321
# helper for development use only
322-
function __init(f,x,M,p=nothing; kwargs...)
323-
s = init(ZeroProblem(f,x), M, p;kwargs...)
324-
(M=s.M, F=s.F, state=s.state, options=s.options,logger=s.logger)
322+
function __init(f, x, M, p=nothing; kwargs...)
323+
s = init(ZeroProblem(f, x), M, p; kwargs...)
324+
(M=s.M, F=s.F, state=s.state, options=s.options, logger=s.logger)
325325
end
326326

327327
"""

test/test_derivative_free.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ if !isinteractive()
307307
Roots.Order8(),
308308
Roots.Order16(),
309309
Roots.Sidi(2),
310-
Roots.Sidi(3)
310+
Roots.Sidi(3),
311311
]
312312
results = [run_df_tests((f, b) -> find_zero(f, b, M), name="$M") for M in Ms]
313313

@@ -358,7 +358,7 @@ if !isinteractive()
358358
Roots.Order5(),
359359
Roots.Order8(),
360360
Roots.Order16(),
361-
Roots.Sidi(2)
361+
Roots.Sidi(2),
362362
]
363363
Ts = [Float16, Float32, BigFloat]
364364

test/test_find_zero.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ struct Order3_Test <: Roots.AbstractSecantMethod end
2828
Roots.Thukral16(),
2929
Roots.LithBoonkkampIJzerman(3, 0),
3030
Roots.LithBoonkkampIJzerman(4, 0),
31-
Roots.Sidi(2)
31+
Roots.Sidi(2),
3232
]
3333

3434
## different types of initial values
@@ -597,8 +597,8 @@ end
597597
end
598598

599599
@testset "similar methods" begin
600-
Lsidi,Lsec = Roots.Tracks(),Roots.Tracks()
600+
Lsidi, Lsec = Roots.Tracks(), Roots.Tracks()
601601
find_zero(sin, 3.0, Roots.Sidi(1); tracks=Lsidi)
602602
find_zero(sin, 3.0, Roots.Secant(); tracks=Lsec)
603-
@test Lsidi.xfₛ[3:end] == Lsec.xfₛ[3:end] # drop x₀x₁ ordering
603+
@test Lsidi.xfₛ[3:end] == Lsec.xfₛ[3:end] # drop x₀x₁ ordering
604604
end

0 commit comments

Comments
 (0)