Skip to content

Commit f870397

Browse files
committed
Workaround for extension handling in ExplicitImports
1 parent 1557356 commit f870397

File tree

2 files changed

+15
-3
lines changed

2 files changed

+15
-3
lines changed

ext/SpecialFunctionsChainRulesCoreExt.jl

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
module SpecialFunctionsChainRulesCoreExt
22

3-
using SpecialFunctions, ChainRulesCore
3+
using SpecialFunctions
4+
using ChainRulesCore: ChainRulesCore
45

5-
import SpecialFunctions: sqrtπ, invπ
6+
using SpecialFunctions: sqrtπ, invπ
67

78
const BESSEL_ORDER_INFO = """
89
derivatives of Bessel functions with respect to the order are not implemented currently:

test/qa.jl

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,14 @@ end
77
@test ExplicitImports.check_no_implicit_imports(SpecialFunctions) === nothing
88

99
# All explicit imports (`using XY: Z`) are loaded via their owners
10-
@test ExplicitImports.check_all_explicit_imports_via_owners(SpecialFunctions) === nothing
10+
@test ExplicitImports.check_all_explicit_imports_via_owners(
11+
SpecialFunctions;
12+
ignore = (
13+
# Ref https://github.com/JuliaTesting/ExplicitImports.jl/issues/92
14+
:invπ, # SpecialFunctions
15+
:sqrtπ, # SpecialFunctions
16+
),
17+
) === nothing
1118

1219
# Limit explicit imports (`using XY: Z`) of non-public names to a minimum
1320
@test ExplicitImports.check_all_explicit_imports_are_public(
@@ -16,6 +23,9 @@ end
1623
:MPFRRoundingMode, # Base.MPFR
1724
:ROUNDING_MODE, # Base.MPFR
1825
:nan_dom_err, # Base.Math
26+
# Ref https://github.com/JuliaTesting/ExplicitImports.jl/issues/92
27+
:invπ, # SpecialFunctions
28+
:sqrtπ, # SpecialFunctions
1929
),
2030
) === nothing
2131

@@ -35,6 +45,7 @@ end
3545
:ROUNDING_MODE, # Base.MPFR
3646
:_fact_table64, # Base
3747
:version, # Base.MPFR
48+
(VERSION < v"1.11" ? (:depwarn,) : ())..., # Base
3849
),
3950
) === nothing
4051

0 commit comments

Comments
 (0)