Skip to content

Commit d0ef09a

Browse files
authored
prefix symbols with _ for 32-bit x86 Windows (#242)
In a case that I believe can only be hit for Clang i686-*-windows-gnu (AKA MinGW), symbols in asm need to be prefixed with `_`. Fixes #237
1 parent 60dec83 commit d0ef09a

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

src/cdefs-compat.h

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,14 +59,19 @@
5959
#endif /* __warn_references */
6060
#endif /* __STDC__ */
6161
#elif defined(__clang__) /* CLANG */
62+
#if defined(_WIN32) && defined(_X86_)
63+
#define openlibm_asm_symbol_prefix "_"
64+
#else
65+
#define openlibm_asm_symbol_prefix ""
66+
#endif
6267
#ifdef __STDC__
6368
#define openlibm_weak_reference(sym,alias) \
64-
__asm__(".weak_reference " #alias); \
65-
__asm__(".set " #alias ", " #sym)
69+
__asm__(".weak_reference " openlibm_asm_symbol_prefix #alias); \
70+
__asm__(".set " openlibm_asm_symbol_prefix #alias ", " openlibm_asm_symbol_prefix #sym)
6671
#else
6772
#define openlibm_weak_reference(sym,alias) \
68-
__asm__(".weak_reference alias");\
69-
__asm__(".set alias, sym")
73+
__asm__(".weak_reference openlibm_asm_symbol_prefix/**/alias");\
74+
__asm__(".set openlibm_asm_symbol_prefix/**/alias, openlibm_asm_symbol_prefix/**/sym")
7075
#endif
7176
#else /* !__ELF__ */
7277
#ifdef __STDC__

0 commit comments

Comments
 (0)