Skip to content

Commit 3e1393d

Browse files
authored
Add missing bracket in summary of NGMRES and O-ACCEL (#1204)
* Add missing bracket in summary of `NGMRES` and `O-ACCEL` * Add tests
1 parent b367149 commit 3e1393d

File tree

2 files changed

+5
-2
lines changed
  • src/multivariate/solvers/first_order
  • test/multivariate/solvers/first_order

2 files changed

+5
-2
lines changed

src/multivariate/solvers/first_order/ngmres.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,13 @@ end
3030

3131

3232
function Base.summary(io::IO, s::NGMRES)
33-
print(io, "Nonlinear GMRES preconditioned with ")
33+
print(io, "Nonlinear GMRES (preconditioned with ")
3434
summary(io, s.nlprecon)
3535
print(io, ")")
3636
return
3737
end
3838
function Base.summary(io::IO, s::OACCEL)
39-
print(io, "O-ACCEL preconditioned with ")
39+
print(io, "O-ACCEL (preconditioned with ")
4040
summary(io, s.nlprecon)
4141
print(io, ")")
4242
return

test/multivariate/solvers/first_order/ngmres.jl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ using Optim, Test
44
@testset "N-GMRES" begin
55
method = NGMRES
66
solver = method()
7+
test_summary(solver, "Nonlinear GMRES (preconditioned with Gradient Descent)")
78

89
skip = ("Trigonometric",)
910
run_optim_tests(
@@ -94,6 +95,8 @@ end
9495
@testset "O-ACCEL" begin
9596
method = OACCEL
9697
solver = method()
98+
test_summary(solver, "O-ACCEL (preconditioned with Gradient Descent)")
99+
97100
skip = ("Trigonometric",)
98101
run_optim_tests(
99102
solver;

0 commit comments

Comments
 (0)