Teach audit to check multiple CSL libraries (#932)

* Teach audit to check multiple CSL libraries

In addition to `libgomp`, it's possible that a library links against libatomic,
so we need to check also that one.

* Update src/auditor/compiler_abi.jl

Co-authored-by: Elliot Saba <[email protected]>

Co-authored-by: Elliot Saba <[email protected]>

Author: giordano

src/Auditor.jl

@@ -90,8 +90,9 @@ function audit(prefix::Prefix, src_name::AbstractString = "";
                     if isdynamic(oh)
                         # Check that the libgfortran version matches
                         all_ok &= check_libgfortran_version(oh, platform; verbose=verbose, has_csl = has_csl)
-                        # Check whether the library depends on libgomp
-                        all_ok &= check_libgomp(oh, platform; verbose=verbose, has_csl = has_csl)
+                        # Check whether the library depends on any of the most common
+                        # libraries provided by `CompilerSupportLibraries_jll`.
+                        all_ok &= check_csl_libs(oh, platform; verbose=verbose, has_csl=has_csl)
                         # Check that the libstdcxx string ABI matches
                         all_ok &= check_cxxstring_abi(oh, platform; verbose=verbose)
                         # Check that this binary file's dynamic linkage works properly.  Note to always

src/auditor/compiler_abi.jl

@@ -63,24 +63,33 @@ function check_libgfortran_version(oh::ObjectHandle, platform::AbstractPlatform;
     return true
 end
 
-function check_libgomp(oh::ObjectHandle, platform::AbstractPlatform; verbose::Bool = false,
-                       has_csl::Bool = true)
-    has_libgomp = false
-    try
-        libs = basename.(path.(DynamicLinks(oh)))
-        has_libgomp = length(filter(l -> occursin("libgomp", l), libs)) >= 1
+function check_csl_libs(oh::ObjectHandle, platform::AbstractPlatform; verbose::Bool=false,
+                        has_csl::Bool=true, csl_libs::Vector{String}=["libgomp", "libatomic"])
+    if has_csl
+        # No need to do any check, CompilerSupportLibraries_jll is already a dependency
+        return true
+    end
+
+    # Collect list of dependencies
+    libs = try
+        basename.(path.(DynamicLinks(oh)))
     catch e
         if isa(e, InterruptException)
             rethrow(e)
         end
-        @warn "$(path(oh)) could not be scanned for libgomp dependency!" exception=(e, catch_backtrace())
+        @warn "$(path(oh)) could not be scanned for $(lib) dependency!" exception=(e, catch_backtrace())
         return true
     end
 
-    if !has_csl && has_libgomp
-        csl_warning("libgomp")
-        return false
+    # If any of the libs is a library provided by
+    # `CompilerSupportLibraries_jll`, suggest to add the package as dependency
+    for lib in csl_libs
+        if length(filter(l -> occursin(lib, l), libs)) >= 1
+            csl_warning(lib)
+            return false
+        end
     end
+
     return true
 end