[Auditor] Add pass to make all binary files executable (#992)

Author: giordano

src/Auditor.jl

@@ -85,6 +85,13 @@ function audit(prefix::Prefix, src_name::AbstractString = "";
                     all_ok &= check_isa(oh, platform, prefix; verbose=verbose, silent=silent)
                     # Check that the OS ABI is set correctly (often indicates the wrong linker was used)
                     all_ok &= check_os_abi(oh, platform, verbose = verbose)
+                    # Make sure all binary files are executables, if libraries aren't
+                    # executables Julia may not be able to dlopen them:
+                    # https://github.com/JuliaLang/julia/issues/38993.  In principle this
+                    # should be done when autofix=true, but we have to run this fix on MKL
+                    # for Windows, for which however we have to set autofix=false:
+                    # https://github.com/JuliaPackaging/Yggdrasil/pull/922.
+                    all_ok &= ensure_executability(oh; verbose=verbose, silent=silent)
 
                     # If this is a dynamic object, do the dynamic checks
                     if isdynamic(oh)

src/auditor/filesystems.jl

@@ -43,3 +43,27 @@ function check_absolute_paths(prefix::Prefix, all_files::Vector; silent::Bool =
 
     return true
 end
+
+function ensure_executability(oh::ObjectHandle; verbose::Bool=false, silent::Bool=false)
+    old_mode = filemode(path(oh))
+    # Execution permissions only for users who can read the file
+    read_mask = (old_mode & 0o444) >> 2
+    # Check whether the file has executable permission for all
+    if old_mode & read_mask != read_mask
+        if verbose
+            @info "Making $(path(oh)) executable"
+        end
+        try
+            # Add executable permission for all users that can read the file
+            chmod(path(oh), old_mode | read_mask)
+        catch e
+            if isa(e, InterruptException)
+                rethrow(e)
+            end
+            if !silent
+                @warn "$(path(oh)) could not be made executable!" exception=(e, catch_backtrace())
+            end
+        end
+    end
+    return true
+end

test/auditing.jl

@@ -517,6 +517,52 @@ end
     end
 end
 
+@testset "Auditor - execution permission" begin
+    mktempdir() do build_path
+        build_output_meta = nothing
+        product = LibraryProduct("libfoo", :libfoo)
+        @test_logs (:info, r"Making .*libfoo.* executable") match_mode=:any begin
+            build_output_meta = autobuild(
+                build_path,
+                "exec",
+                v"1.0.0",
+                # No sources
+                FileSource[],
+                # Build a library without execution permissions
+                raw"""
+                mkdir -p "${libdir}"
+                cc -o "${libdir}/libfoo.${dlext}" -fPIC -shared /usr/share/testsuite/c/dyn_link/libfoo/libfoo.c
+                chmod 640 "${libdir}/libfoo.${dlext}"
+                """,
+                # Build for our platform
+                [platform],
+                # Ensure our library product is built
+                [product],
+                # No dependencies
+                Dependency[];
+                verbose = true,
+                require_license = false
+            )
+        end
+
+        # Extract our platform's build
+        @test haskey(build_output_meta, platform)
+        tarball_path, tarball_hash = build_output_meta[platform][1:2]
+        @test isfile(tarball_path)
+
+        # Unpack it somewhere else
+        @test verify(tarball_path, tarball_hash)
+        testdir = joinpath(build_path, "testdir")
+        mkdir(testdir)
+        unpack(tarball_path, testdir)
+        libfoo_path = joinpath(testdir, build_output_meta[platform][4][product]["path"])
+        # Tar.jl normalizes permissions of executable files to 0o755, instead of
+        # recording exact original permissions:
+        # https://github.com/JuliaIO/Tar.jl/blob/37766a22f5a6ac9f07022d83debd5db7d7a4b896/README.md#permissions
+        @test_broken filemode(libfoo_path) & 0o777 == 0o750
+    end
+end
+
 @testset "Auditor - other checks" begin
     mktempdir() do build_path
         @test_logs (:error, r"does not match the hard-float ABI") match_mode=:any begin