Skip to content

Make .pkg/select_artifacts.jl parse riscv64 #1366

@giordano

Description

@giordano

This line

platform = augment_platform!(HostPlatform(parse(Platform, target_triplet)))
freaks out on Julia < 1.12 (and in particular v1.7 used in Yggdrasil) when trying to parse a triplet like riscv64-linux-gnu: JuliaPackaging/Yggdrasil#10503 (comment). We need to make parse(::Type{Platform}, ::String) digest riscv64 as an architecture for Julia < 1.12 only. Basically a smaller version of https://github.com/JuliaPackaging/BinaryBuilderBase.jl/blob/bc1c293e367714537136d22ece9d81a82731b009/src/riscv64.jl, only whatever is needed for parsing, probably only the parse method at https://github.com/JuliaPackaging/BinaryBuilderBase.jl/blob/bc1c293e367714537136d22ece9d81a82731b009/src/riscv64.jl#L92, without all the rest, we don't need anything of the rest.

@eschnett I think you were motivated to look into this? I don't have much time to work on this myself at the moment, it should be fairly simple, only doing the minimal changes to make parsing work correctly.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions