fix tests

Author: IanButterworth

test/dependencies.jl

@@ -367,40 +367,30 @@ end
         end
 
         @testset "PackageSpec with version" begin
+            platform = Platform("x86_64", "linux"; libc="musl", cxxstring_abi="cxx11")
             # Install a dependency with a specific version number.
-            with_temp_project() do dir
-                prefix = Prefix(dir)
-                dependencies = [
-                    PackageSpec(; name="CMake_jll", version = v"3.24.3")
-                ]
-                platform = Platform("x86_64", "linux"; libc="musl", cxxstring_abi="cxx11")
-                if v"1.9" <= VERSION < v"1.11"
-                    # For reasons I can't understand, in CI on GitHub Actions (and only
-                    # there, can't reproduce the same behaviour locally) the error thrown
-                    # inside the `setup_dependencies` "escapes" the `try` block. For lack of
-                    # time to debug this stupid thing we just mark this step as broken and
-                    # move on, it's really broken anyway.
-                    @test false broken=true
-                else
-                    try
-                        test_setup_dependencies(prefix, dependencies, platform)
-                    catch
-                        if VERSION>=v"1.9"
-                            # This test is expected to be broken on Julia v1.9+
-                            @test false broken=true
-                        else
-                            # For previous versions we don't expect errors and we
-                            # want to see them.
-                            rethrow()
-                        end
-                    end
+            @testset for version in (v"3.24.3+0", "3.24.3")
+                with_temp_project() do dir
+                    prefix = Prefix(dir)
+                    dependencies = [
+                        PackageSpec(; name="CMake_jll", version = version)
+                    ]
+                    test_setup_dependencies(prefix, dependencies, platform)
+                    # The directory contains also executables from CMake dependencies.
+                    # Test will fail if `setup_dependencies` above failed.
+                    @test readdir(joinpath(destdir(dir, platform), "bin")) == ["c_rehash", "cmake", "cpack", "ctest", "openssl"] broken=VERSION>=v"1.9"
+                end
+            end
+            @testset "should error if build is missing from a specific VersionNumber" begin
+                with_temp_project() do dir
+                    prefix = Prefix(dir)
+                    dependencies = [
+                        PackageSpec(; name="CMake_jll", version = v"3.24.3")
+                    ]
+                    @test_throws test_setup_dependencies(prefix, dependencies, platform)
                 end
-                # The directory contains also executables from CMake dependencies.
-                # Test will fail if `setup_dependencies` above failed.
-                @test readdir(joinpath(destdir(dir, platform), "bin")) == ["c_rehash", "cmake", "cpack", "ctest", "openssl"] broken=VERSION>=v"1.9"
             end
         end
-
     end
 end