Add from_current_manifest option to use active environment versions #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a `from_current_manifest` kwarg to collect_artifact_metas (and by extension collect_artifact_paths) that when set to true, uses the versions from the currently active environment's manifest instead of calling Pkg.add. This allows reproducing environments from a simple Manifest.toml by activating that environment first, then using from_current_manifest=true to collect artifacts using the exact versions specified in the manifest. Implementation details: - Moved pkg_io and stdlib_resolve\! definitions outside the if/else block - Fixed indentation for code inside the do blocks - When from_current_manifest=true, uses current Pkg.Types.Context() to access manifest - Handles packages without tree_hash (like stdlib packages) by attempting module loading Fixes JuliaPackaging#33 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Contributor
Author
|
@staticfloat I don't fully understand this code, but claude helped and it looked reasonable. Let me know if you have comments. |
Member
|
I'm pretty sure the feature you want already exists, if you just pass the manifest directory in as |
Contributor
Author
|
Kind of, but it still calls |
Member
|
Superceded by #35 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
from_current_manifestkwarg to collect_artifact_metas (and by extension collect_artifact_paths) that when set to true, uses the versions from the currently active environment's manifest instead of calling Pkg.add.This allows reproducing environments from a simple Manifest.toml by activating that environment first, then using from_current_manifest=true to collect artifacts using the exact versions specified in the manifest.
Implementation details:
Fixes #33
🤖 Generated with Claude Code