Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #80 +/- ##
==========================================
- Coverage 93.85% 93.37% -0.49%
==========================================
Files 2 2
Lines 179 166 -13
==========================================
- Hits 168 155 -13
Misses 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
Actual output is: Is the test at Preferences.jl/test/runtests.jl Lines 88 to 91 in 3ffa542 |
5b2d806 to
4b5c249
Compare
4b5c249 to
044c236
Compare
|
Some of the messaging around precompiling has changed and been backported. Ideally we wouldn't have such strict messaging tests here. |
|
Any other way to detect that a package was precompiled? Now I added Preferences.jl/test/runtests.jl Line 91 in 044c236 |
|
Ok, I'm going to merge this so as to have CI working again with minimal changes, but if there are ways to improve testing of the precompilation condition they can be implemented in a follow up PR. |
|
|
This fixes some test failures on nightly, but there are still other errors I don't know what to do about.