Skip to content

Commit e6e9c4e

Browse files
maleadtgiordano
andauthored
Apply suggestions from code review
Co-authored-by: Mosè Giordano <[email protected]>
1 parent e074726 commit e6e9c4e

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

H/HelloWorldOCaml/build_tarballs.jl

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@ sources = [
99

1010
# Bash recipe for building across all platforms
1111
script = raw"""
12-
mkdir -p ${prefix}/bin
12+
mkdir -p ${bindir}
1313
echo 'let () = print_endline "hello world"' > hello.ml
14-
ocamlopt -o ${prefix}/bin/hello_world${exeext} hello.ml
14+
ocamlopt -o ${bindir}/hello_world${exeext} hello.ml
1515
install_license /usr/share/licenses/MIT
1616
"""
1717

@@ -20,9 +20,7 @@ install_license /usr/share/licenses/MIT
2020
platforms = supported_platforms()
2121

2222
# OCaml 5.0 dropped support for 32-bit targets
23-
filter!(p -> !(arch(p) == "i686"), platforms)
24-
filter!(p -> !(arch(p) == "armv6l"), platforms)
25-
filter!(p -> !(arch(p) == "armv7l"), platforms)
23+
filter!(p -> nbits(p) != 32, platforms)
2624

2725
# Not yet supported by our OCaml toolchain
2826
filter!(p -> !(Sys.isfreebsd(p)), platforms)

0 commit comments

Comments
 (0)