Skip to content

Commit 276e4f0

Browse files
authored
Merge pull request #465 from JuliaParallel/jps/no-cache
Sch: Temporarily disable chunk cache
2 parents 2110d62 + 38b1b44 commit 276e4f0

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

src/sch/Sch.jl

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1508,6 +1508,7 @@ function do_task(to_proc, task_desc)
15081508
fetch_tasks = map(Iterators.zip(_data,_ids)) do (x, id)
15091509
@async begin
15101510
timespan_start(ctx, :move, (;thunk_id, id), (;f, id, data=x))
1511+
#= FIXME: This isn't valid if x is written to
15111512
x = if x isa Chunk
15121513
value = lock(TASK_SYNC) do
15131514
if haskey(CHUNK_CACHE, x)
@@ -1548,8 +1549,9 @@ function do_task(to_proc, task_desc)
15481549
_x
15491550
end
15501551
else
1551-
@invokelatest move(to_proc, x)
1552-
end
1552+
=#
1553+
x = @invokelatest move(to_proc, x)
1554+
#end
15531555
@dagdebug thunk_id :move "Moved argument $id to $to_proc: $x"
15541556
timespan_finish(ctx, :move, (;thunk_id, id), (;f, id, data=x); tasks=[Base.current_task()])
15551557
return x

test/scheduler.jl

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -487,9 +487,13 @@ function testevicted(x)
487487
x
488488
end
489489
end
490+
491+
@test_skip "Chunk Caching"
492+
#=
490493
@testset "Chunk Caching" begin
491494
compute(delayed(testevicted)(delayed(testpresent)(c1,c2)))
492495
end
496+
=#
493497

494498
@testset "MemPool.approx_size" begin
495499
for (obj, size) in [

0 commit comments

Comments
 (0)