Skip to content

Commit e2c1b4d

Browse files
JSON3Ext: Deprecate Dagger.render_logs for :chrome_trace (#604)
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
1 parent 4ee41a6 commit e2c1b4d

File tree

2 files changed

+1
-1
lines changed

2 files changed

+1
-1
lines changed

docs/src/logging-visualization.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ Built-in `IO` support exists for:
2424
Built-in rendering support exists for:
2525
- `render_logs(logs, :graphviz)` to generate a graph diagram of executed tasks and their dependencies (requires `GraphViz.jl` to be loaded)
2626
- `render_logs(logs, :plots_gantt)` to generate a Gantt chart of task execution across all processors (requires `Plots.jl` and `DataFrames.jl` to be loaded)
27-
- `render_logs(logs, :chrome_trace)` to generate a `String` with chrome-trace formatted task execution timeline
2827

2928
The latter (`MultiEventLog`) allows for continuously rendering logs as they're
3029
generated, permitting real-time visualization of Dagger's operations. This

ext/JSON3Ext.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ function logs_to_chrome_trace(logs::Dict)
8080
end
8181

8282
function Dagger.render_logs(logs::Dict, ::Val{:chrome_trace})
83+
@warn "Dagger.render_logs(logs, :chrome_trace) is deprecated, use Dagger.show_logs(io, logs, :chrome_trace) instead." maxlog=1
8384
return JSON3.write(logs_to_chrome_trace(logs))
8485
end
8586

0 commit comments

Comments
 (0)