stencils: Fix support for stencils with > 2 dims #673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpsamaroo
force-pushed
the
jps/stencils-3d
branch
2 times, most recently
from
48795a3 to
c06f2c8
Compare
jpsamaroo
force-pushed
the
jps/stencils-3d
branch
from
c06f2c8 to
6ebc52b
Compare
Member
Author
|
This is broken on some backends for unknown reasons, so I'm merging this and going to deal with that later. Hopefully it's an unrelated bug in Datadeps that I have a fix for. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HaloArray didn't properly support representing all of the halo regions that stencils with 3 or more dimensions require. This PR fixes the HaloArray and surrounding stencil code, and adds a test for 3D and 4D cases (5D causes too much compile time to be worth testing).
Fixes #669
Written by Claude