Skip to content

Commit 8f5af29

Browse files
authored
Merge pull request #140 from JuliaParallel/amitm/testfixups
test fixups
2 parents 83f4ba3 + 08974b6 commit 8f5af29

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ It is also important to note that the localparts of the DArray is collected from
241241
when the DArray object on the process creating the DArray is collected. It is therefore important to maintain
242242
a reference to a DArray object on the creating process for as long as it is being computed upon.
243243

244-
`darray_closeall()` is another useful function to manage distributed memory. It releases all darrays created from
244+
`d_closeall()` is another useful function to manage distributed memory. It releases all darrays created from
245245
the calling process, including any temporaries created during computation.
246246

247247
Working with distributed non-array data (requires Julia 0.6)
@@ -427,6 +427,6 @@ function foo(d::DArray)
427427
end
428428
spmd(foo,....)
429429
```
430-
Without the `myid()` check, the `spmd` call to `foo` would execute `map!` from all nodes, which is not what we probably want.
430+
Without the `myid()` check, the `spmd` call to `foo` would execute `map!` from all nodes, which is not what we probably want.
431431

432432
Similarly `@everywhere` from within a SPMD run should also be driven from the master node only.

test/darray.jl

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,10 @@ using SpecialFunctions
4343

4444
@testset "Global DArray serialization issue #134" begin
4545
global A134 = drandn(1)
46-
@test DArray(I -> DistributedArrays.localpart(A134), A134) == A134
46+
D2 = DArray(I -> DistributedArrays.localpart(A134), A134)
47+
@test D2 == A134
48+
close(A134)
49+
close(D2)
4750
end
4851

4952
@testset "empty_localpart should work when only constructor (not conversion is defined)" begin
@@ -156,7 +159,7 @@ end
156159

157160
check_leaks()
158161

159-
@testset "copy!" begin
162+
@testset "test copy!" begin
160163
D1 = dzeros((10,10))
161164
r1 = remotecall_wait(() -> randn(3,10), workers()[1])
162165
r2 = remotecall_wait(() -> randn(7,10), workers()[2])

0 commit comments

Comments
 (0)