fixup! Use LibSSH.jl to set up an SSH server for the SSHManager tests

Author: JamesWrigley

.github/workflows/ci.yml

@@ -23,15 +23,15 @@ jobs:
       fail-fast: false
       matrix:
         version:
-          - 'nightly'
+          # - 'nightly'
           - '1'
         os:
           - ubuntu-latest
-          - macOS-latest
-          - windows-latest
+          # - macOS-latest
+          # - windows-latest
         arch:
           - x64
-          - x86
+          # - x86
         exclude:
           - os: macOS-latest
             arch: x86

test/distributed_exec.jl

@@ -807,6 +807,12 @@ if Sys.isunix() # aka have ssh
             append!(hosts, localhost_aliases)
         end
 
+        # CI machines sometimes don't already have a .ssh directory
+        ssh_dir = joinpath(homedir(), ".ssh")
+        if !isdir(ssh_dir)
+            mkdir(ssh_dir)
+        end
+
         print("\nTesting SSH addprocs with $(length(hosts)) workers...\n")
         new_pids = addprocs_with_testenv(hosts; sshflags=sshflags)
         @test length(new_pids) == length(hosts)
@@ -828,14 +834,13 @@ if Sys.isunix() # aka have ssh
         test_n_remove_pids(new_pids)
 
         print("\nssh addprocs with tunnel (SSH multiplexing)\n")
+
+        controlpath = joinpath(ssh_dir, "julia-$(ENV["USER"])@localhost:2222")
         new_pids = addprocs_with_testenv([("localhost", num_workers)]; tunnel=true, multiplex=true, sshflags=sshflags)
         @test length(new_pids) == num_workers
-        mktempdir() do path
-            controlpath = joinpath(path, "julia-$(ENV["USER"])@localhost:2222")
-            @test issocket(controlpath)
-            test_n_remove_pids(new_pids)
-            @test :ok == timedwait(()->!issocket(controlpath), 10.0; pollint=0.5)
-        end
+        @test issocket(controlpath)
+        test_n_remove_pids(new_pids)
+        @test :ok == timedwait(()->!issocket(controlpath), 10.0; pollint=0.5)
 
         print("\nAll supported formats for hostname\n")
         h1 = "localhost"