Apply suggestions from code review

Co-authored-by: Mosè Giordano <[email protected]>

Author: vchuravy

.gitignore

@@ -5,4 +5,4 @@ libjuliampi.dylib
 *.mem
 *.so
 Manifest.toml
-LocalPreferences.toml
+LocalPreferences.toml

lib/MPIPreferences/src/MPIPreferences.jl

@@ -41,14 +41,14 @@ function use_jll_binary(binary = Sys.iswindows() ? "MicrosoftMPI_jll" : "MPICH_j
 end
 
 function use_system_binary(;
-        library=["libmpi", "libmpi_ibm", "msmpi", "libmpich", "libmpitrampoline"],
+        library_names=["libmpi", "libmpi_ibm", "msmpi", "libmpich", "libmpitrampoline"],
         mpiexec="mpiexec",
         abi=nothing,
         export_prefs=false,
         force=true,
     )
 
-    libmpi = find_library(library)
+    libmpi = find_library(library_names)
     if libmpi == ""
         error("MPI library could not be found")
     end

src/MPI.jl

@@ -36,7 +36,7 @@ end
 
 import MPIPreferences
 
-@static if MPIPreferences.binary == "MPICH_jll"
+if MPIPreferences.binary == "MPICH_jll"
     import MPICH_jll: libmpi, mpiexec
     const libmpiconstants = nothing
 elseif MPIPreferences.binary == "OpenMPI_jll"

src/consts/consts.jl

@@ -43,4 +43,4 @@ end
     $(Expr(:block, initexprs...))
 end
 
-end
+end