define operators for logical types (#719)

Author: simonbyrne

src/buffers.jl

@@ -1,12 +1,3 @@
-const MPIInteger = Union{Int8, UInt8, Int16, UInt16, Int32, UInt32, Int64, UInt64}
-const MPIFloatingPoint = Union{Float32, Float64}
-const MPIComplex = Union{ComplexF32, ComplexF64}
-
-const MPIDatatype = Union{Char,
-                          Int8, Int16, Int32, Int64,
-                          UInt8, UInt16, UInt32, UInt64,
-                          Float32, Float64, ComplexF32, ComplexF64}
-
 MPIBuffertype{T} = Union{Ptr{T}, Array{T}, SubArray{T}, Ref{T}}
 MPIBuffertypeOrConst{T} = Union{MPIBuffertype{T}, SentinelPtr}
 

src/datatypes.jl

@@ -84,6 +84,11 @@ function to_type(datatype::Datatype)
     return nothing
 end
 
+# "native" MPI datatypes
+const MPIInteger = Union{Int8, UInt8, Int16, UInt16, Int32, UInt32, Int64, UInt64}
+const MPIFloatingPoint = Union{Float32, Float64}
+const MPIComplex = Union{ComplexF32, ComplexF64}
+const MPILogical = Union{Bool}
 
 # predefined
 _defined_datatype_methods = Set{Type}()

src/deprecated.jl

@@ -244,3 +244,8 @@ import Base: @deprecate
     stat = Recv!(buf, Get_source(stat), Get_tag(stat), comm)
     (true, MPI.deserialize(buf), stat)
 end, false)
+
+Base.@deprecate_binding MPIDatatype Union{Char,
+                          Int8, Int16, Int32, Int64,
+                          UInt8, UInt16, UInt32, UInt64,
+                          Float32, Float64, ComplexF32, ComplexF64} false

src/operators.jl

@@ -61,6 +61,9 @@ Op(::typeof(*), ::Type{T}; iscommutative=true) where {T<:Union{MPIInteger,MPIFlo
 Op(::typeof(&), ::Type{T}; iscommutative=true) where {T<:MPIInteger} = BAND
 Op(::typeof(|), ::Type{T}; iscommutative=true) where {T<:MPIInteger} = BOR
 Op(::typeof(⊻), ::Type{T}; iscommutative=true) where {T<:MPIInteger} = BXOR
+Op(::typeof(&), ::Type{T}; iscommutative=true) where {T<:MPILogical} = LAND
+Op(::typeof(|), ::Type{T}; iscommutative=true) where {T<:MPILogical} = LOR
+Op(::typeof(⊻), ::Type{T}; iscommutative=true) where {T<:MPILogical} = LXOR
 
 
 function free(op::Op)

test/test_allreduce.jl

@@ -47,6 +47,14 @@ for T = [Int]
     end
 end
 
+@test !MPI.Allreduce(false, |, MPI.COMM_WORLD)
+@test MPI.Allreduce(true, |, MPI.COMM_WORLD)
+@test !MPI.Allreduce(false, &, MPI.COMM_WORLD)
+@test MPI.Allreduce(true, &, MPI.COMM_WORLD)
+@test !MPI.Allreduce(false, ⊻, MPI.COMM_WORLD)
+@test MPI.Allreduce(true, ⊻, MPI.COMM_WORLD) ⊻ iseven(comm_size)
+
+
 MPI.Barrier( MPI.COMM_WORLD )
 
 GC.gc()