Add Cart_coords function to comply with ! suffix convention (#273)

Also deprecate existing `Cart_coords!` methods

Author: samo-lin

src/deprecated.jl

@@ -9,7 +9,7 @@ const FINALIZE_ATEXIT = Ref(true)
 @deprecate Info_get(info::Info,key::AbstractString) info[Symbol(key)] false
 @deprecate Info_delete(info::Info,key::AbstractString) delete!(info, Symbol(key)) false
 @deprecate Info_free(info::Info) free(info) false
-
+@deprecate Cart_coords!(comm::Comm, maxdims::Integer) Cart_coords(comm, maxdims) false
 
 # window functions
 @deprecate(Win_create(base::Array{T}, info::Info, comm::Comm, win::Win) where {T},

src/mpi-base.jl

@@ -376,7 +376,7 @@ function Cart_coords!(comm::Comm, rank::Integer, maxdims::Integer, coords::MPIBu
           comm.val, rank, maxdims, coords, 0)
 end
 
-function Cart_coords!(comm::Comm, maxdims::Integer)
+function Cart_coords(comm::Comm, maxdims::Integer)
     ccoords = Vector{Cint}(undef, maxdims)
     rank    = Comm_rank(comm)
     Cart_coords!(comm, rank, maxdims, ccoords)

test/test_cart_coords.jl

@@ -17,7 +17,7 @@ MPI.Cart_coords!(comm_cart, rank, ndims, ccoords)
 @test all(ccoords .>= 0) 
 @test all(ccoords .< dims)
 
-coords = MPI.Cart_coords!(comm_cart, ndims)
+coords = MPI.Cart_coords(comm_cart, ndims)
 @test all(coords .>= 0)
 @test all(coords .< dims)
 

test/test_cart_shift.jl

@@ -10,7 +10,7 @@ periods = [0,1,0]
 dims = [0,0,0]
 MPI.Dims_create!(nnodes, dims)
 comm_cart = MPI.Cart_create(comm, dims, periods, reorder)
-coords = MPI.Cart_coords!(comm_cart, ndims)
+coords = MPI.Cart_coords(comm_cart, ndims)
 disp = 1
 
 for i in 0:2