update one sided API (#496)

- Make use of exclamation consistent
- Allocations return Arrays
- add docs

Author: simonbyrne

deps/build.jl

@@ -50,7 +50,7 @@ if haskey(ENV, "JULIA_MPIEXEC")
     end
     update_config = true
 end
-    
+
 
 if update_config
     open(config_toml, write=true) do f
@@ -75,11 +75,11 @@ if binary == "system"
     if libmpi == ""
         error("libmpi could not be found")
     end
-    
+
     const mpiexec_cmd = Cmd(mpiexec isa String ? [mpiexec] : mpiexec)
-    
+
     _doc_external(fname) = ""
-    
+
     include(joinpath("..","src","implementations.jl"))
 
     @info "Using implementation" libmpi mpiexec_cmd MPI_LIBRARY_VERSION_STRING

deps/consts_microsoftmpi.jl

@@ -100,6 +100,11 @@ const MPI_MODE_DELETE_ON_CLOSE = reinterpret(Cint, 0x00000010)
 const MPI_MODE_UNIQUE_OPEN = reinterpret(Cint, 0x00000020)
 const MPI_MODE_SEQUENTIAL = reinterpret(Cint, 0x00000100)
 const MPI_MODE_APPEND = reinterpret(Cint, 0x00000080)
+const MPI_MODE_NOCHECK    = Cint(1024)
+const MPI_MODE_NOSTORE    = Cint(2048)
+const MPI_MODE_NOPUT      = Cint(4096)
+const MPI_MODE_NOPRECEDE  = Cint(8192)
+const MPI_MODE_NOSUCCEED  = Cint(16384)
 
 const MPI_SEEK_SET = Cint(600)
 const MPI_SEEK_CUR = Cint(602)

deps/consts_mpich.jl

@@ -105,6 +105,11 @@ const MPI_MODE_DELETE_ON_CLOSE = Cint(16)
 const MPI_MODE_UNIQUE_OPEN = Cint(32)
 const MPI_MODE_SEQUENTIAL = Cint(256)
 const MPI_MODE_APPEND = Cint(128)
+const MPI_MODE_NOCHECK    = Cint(1024)
+const MPI_MODE_NOSTORE    = Cint(2048)
+const MPI_MODE_NOPUT      = Cint(4096)
+const MPI_MODE_NOPRECEDE  = Cint(8192)
+const MPI_MODE_NOSUCCEED  = Cint(16384)
 
 const MPI_SEEK_SET = Cint(600)
 const MPI_SEEK_CUR = Cint(602)

deps/consts_openmpi.jl

@@ -112,6 +112,11 @@ const MPI_MODE_DELETE_ON_CLOSE = Cint(16)
 const MPI_MODE_UNIQUE_OPEN = Cint(32)
 const MPI_MODE_SEQUENTIAL = Cint(256)
 const MPI_MODE_APPEND = Cint(128)
+const MPI_MODE_NOCHECK    = Cint(1)
+const MPI_MODE_NOPRECEDE  = Cint(2)
+const MPI_MODE_NOPUT      = Cint(4)
+const MPI_MODE_NOSTORE    = Cint(8)
+const MPI_MODE_NOSUCCEED  = Cint(16)
 
 const MPI_SEEK_SET = Cint(600)
 const MPI_SEEK_CUR = Cint(602)

deps/gen_consts.jl

@@ -143,6 +143,11 @@ MPI_Cints = [
     :MPI_MODE_UNIQUE_OPEN,
     :MPI_MODE_SEQUENTIAL,
     :MPI_MODE_APPEND,
+    :MPI_MODE_NOCHECK,
+    :MPI_MODE_NOSTORE,
+    :MPI_MODE_NOPUT,
+    :MPI_MODE_NOPRECEDE,
+    :MPI_MODE_NOSUCCEED,
     :MPI_SEEK_SET,
     :MPI_SEEK_CUR,
     :MPI_SEEK_END,

src/deprecated.jl

@@ -186,4 +186,23 @@ import Base: @deprecate
 
 
 # Deprecated in v0.19
-@deprecate(Init_thread(required::ThreadLevel; kwargs...), Init(;threadlevel=required, kwargs...), false)
+@deprecate(Init_thread(required::ThreadLevel; kwargs...), Init(;threadlevel=required, kwargs...), false)
+
+# Deprecated in v0.20
+@deprecate(Win_allocate_shared(::Type{T}, len, comm::Comm; kwargs...) where T,
+    Win_allocate_shared(Ptr{T}, len, comm; kwargs...), false)
+@deprecate(Win_shared_query(win::Win, rank::Int),
+  Win_shared_query(Ptr{Cvoid}, win, rank), false)
+
+@deprecate(Win_attach(win::Win, base::AbstractArray{T}) where T, Win_attach!(win, base), false)
+@deprecate(Win_detach(win::Win, base::AbstractArray{T}) where T, Win_detach!(win, base), false)
+
+@deprecate(Get(origin, rank, disp, win), Get!(origin, rank, disp, win), false)
+@deprecate(Get(origin, rank, win), Get!(origin, rank, win), false)
+@deprecate(Put(origin, rank, disp, win), Put!(origin, rank, disp, win), false)
+@deprecate(Put(origin, rank, win), Put!(origin, rank, win), false)
+@deprecate(Fetch_and_op(sourceval, returnval, target_rank::Integer, target_disp::Integer, op::Op, win::Win),
+  Fetch_and_op!(sourceval, returnval, target_rank, target_disp, op, win), false)
+
+@deprecate(Accumulate(origin, rank, disp, op, win), Accumulate!(origin, rank, disp, op, win), false)
+@deprecate(Get_accumulate(origin, result, rank, disp, op, win), Get_accumulate!(origin, result, rank, disp, op, win), false)