Skip to content

Commit cbf9977

Browse files
committed
better error messages
1 parent 2962c77 commit cbf9977

File tree

2 files changed

+15
-33
lines changed

2 files changed

+15
-33
lines changed

.github/workflows/UnitTests.yml

Lines changed: 14 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@ jobs:
2828
fail-fast: false
2929

3030
runs-on: ${{ matrix.os }}
31-
env:
32-
JULIA_MPIEXEC_ARGS: ${{ matrix.mpiexec_args }}
3331

3432
steps:
3533
- name: Cancel Previous Runs
@@ -44,25 +42,14 @@ jobs:
4442
with:
4543
arch: ${{ matrix.julia_arch }}
4644
version: ${{ matrix.julia_version }}
47-
48-
# https://discourse.julialang.org/t/recommendation-cache-julia-artifacts-in-ci-services/35484
49-
- name: Cache artifacts
50-
uses: actions/cache@v1
51-
env:
52-
cache-name: cache-artifacts
53-
with:
54-
path: ~/.julia/artifacts
55-
key: ${{ runner.os }}-test-${{ env.cache-name }}-${{ hashFiles('**/Project.toml') }}
56-
restore-keys: |
57-
${{ runner.os }}-test-${{ env.cache-name }}-
58-
${{ runner.os }}-test-
59-
${{ runner.os }}-
45+
- uses: julia-actions/cache@v1
6046

6147
- name: add MPIPreferences
6248
shell: julia --color=yes --project=. {0}
6349
run: |
6450
using Pkg
6551
Pkg.develop(path="lib/MPIPreferences")
52+
6653
- uses: julia-actions/julia-buildpkg@latest
6754
- uses: julia-actions/julia-runtest@latest
6855

@@ -164,26 +151,21 @@ jobs:
164151
with:
165152
version: ${{ matrix.julia_version }}
166153

167-
# https://discourse.julialang.org/t/recommendation-cache-julia-artifacts-in-ci-services/35484
168-
- name: Cache artifacts
169-
uses: actions/cache@v1
170-
env:
171-
cache-name: cache-artifacts
172-
with:
173-
path: ~/.julia/artifacts
174-
key: ${{ runner.os }}-test-${{ env.cache-name }}-${{ hashFiles('**/Project.toml') }}
175-
restore-keys: |
176-
${{ runner.os }}-test-${{ env.cache-name }}-
177-
${{ runner.os }}-test-
178-
${{ runner.os }}-
179-
- name: "add MPIPreferences"
180-
run: julia --project -e 'using Pkg; Pkg.develop(path="lib/MPIPreferences")'
181-
- name: "Use system binary"
182-
run: julia --project -e 'using MPIPreferences; MPIPreferences.use_system_binary()'
154+
- uses: julia-actions/cache@v1
155+
156+
- name: add MPIPreferences
157+
shell: julia --color=yes --project=. {0}
158+
run: |
159+
using Pkg
160+
Pkg.develop(path="lib/MPIPreferences")
161+
- name: Use system binary
162+
shell: julia --color=yes --project=. {0}
163+
run: |
164+
using MPIPreferences
165+
MPIPreferences.use_system_binary()
183166
- uses: julia-actions/julia-buildpkg@latest
184167
- uses: julia-actions/julia-runtest@latest
185168

186-
187169
test-intel-linux:
188170
timeout-minutes: 20
189171
strategy:

src/MPI.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ elseif MPIPreferences.binary == "OpenMPI_jll"
4343
elseif MPIPreferences.binary == "MicrosofMPI_jll"
4444
import MicrosofMPI_jll: libmpi, mpiexec
4545
else
46-
error("Unknown MPI binarys")
46+
error("Unknown MPI binary: $(MPIPreferences.binary)")
4747
end
4848

4949
include("consts/consts.jl")

0 commit comments

Comments
 (0)