Skip to content

Commit d20ace4

Browse files
vchuravysloede
andauthored
Apply suggestions from code review
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
1 parent 2af36ef commit d20ace4

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

docs/src/configuration.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,6 @@ julia --project -e 'using MPI; MPI.use_system_binary()'
9292
from transitive dependencies is broken (https://github.com/JuliaPackaging/Preferences.jl/issues/24).
9393
To fix this update your version of Julia, or add `MPIPreferences` as a direct dependency to your project.
9494

95-
The MPI standard doesn't specify the exact application binary interface (ABI).
9695

9796
The following MPI implementations should work out-of-the-box with MPI.jl:
9897

@@ -110,6 +109,7 @@ MPI.use_system_binary
110109
You can use the argument `mpiexec` to provide the name (or full path) of the MPI launcher executable. The default is
111110
`mpiexec`, but some clusters require using the scheduler launcher interface (e.g. `srun`
112111
on Slurm, `aprun` on PBS). If the MPI library has an uncommon name you can provide it in `library_names`.
112+
The MPI standard does not specify the exact application binary interface (ABI).
113113
In case ABI detection fails you can provide a manual choice,
114114
but also open an issue so that the auto-detection can be improved. `export_prefs=true` can be used to copy the preferences into the `Project.toml` instead of creating a
115115
`LocalPreferences.toml` file to hold them.

src/MPI.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ end
3535

3636

3737
import MPIPreferences
38-
import MPIPreferences: use_jll_binary, use_system_binary
39-
export use_jll_binary, use_system_binary
38+
const use_jll_binary = MPIPreferences.use_jll_binary
39+
const use_system_binary = MPIPreferences.use_system_binary
4040

4141
if MPIPreferences.binary == "MPICH_jll"
4242
import MPICH_jll: libmpi, mpiexec

0 commit comments

Comments
 (0)