Add cpu profiling start/stop endpoints #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3641572578
💛 - Coveralls |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
NHDaly
reviewed
Dec 7, 2022
Comment on lines
91
to
94
| uri = HTTP.URI(req.target) | ||
| qp = HTTP.queryparams(uri) | ||
| with_pprof = parse(Bool, get(qp, "pprof", default_pprof())) | ||
| return _stop_cpu_profile(with_pprof) |
Member
There was a problem hiding this comment.
+1 to @quinnj's suggestion to stop the profile as soon as possible, and then do the rest of this work after it's stopped.
Collaborator
Author
|
okay, i re-ran the profiling via the different endpoints ( |
NHDaly
reviewed
Dec 7, 2022
Comment on lines
+215
to
+218
| resp = HTTP.Response(200, "Allocation profiling started.") | ||
| Profile.Allocs.clear() | ||
| Profile.Allocs.start(; sample_rate) | ||
| return HTTP.Response(200, "Allocation profiling started.") | ||
| return resp |
NHDaly
approved these changes
Dec 7, 2022
Member
NHDaly
left a comment
NHDaly
left a comment
There was a problem hiding this comment.
LGTM! :) Thanks @nickrobinson251
nickrobinson251
commented
Dec 7, 2022
Member
|
Awesome! 😊 |
Pull Request Test Coverage Report for Build 3641552542Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 3638763327Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.