refactor: speed up ustrip from redundant dimensional calculation

Author: MilesCranmer

src/arrays.jl

@@ -155,8 +155,7 @@ end
 @inline function ustrip(unit::UnionAbstractQuantity, q::QuantityArray)
     unit, q = promote_except_value(unit, q)
     dimension(unit) == dimension(q) || throw(DimensionError(unit, q))
-    conversion_factor = ustrip(dimension(q) / unit)
-    return ustrip(q) .* conversion_factor
+    return ustrip(q) ./ ustrip(unit)
 end
 @inline dimension(A::QuantityArray) = A.dimensions
 

src/utils.jl

@@ -411,7 +411,7 @@ julia> ustrip(u"km", [1000u"m", 2000u"m"])
 @inline function ustrip(unit::UnionAbstractQuantity, q::UnionAbstractQuantity)
     unit, q = promote_except_value(unit, q)
     dimension(unit) == dimension(q) || throw(DimensionError(unit, q))
-    return ustrip(q / unit)
+    return ustrip(q) / ustrip(unit)
 end
 
 """