fix: import of vars into SymbolicUnits sybmodule

Author: ven-k

src/register_units.jl

@@ -1,4 +1,3 @@
-
 import .Units: UNIT_MAPPING, UNIT_SYMBOLS, UNIT_VALUES, _lazy_register_unit
 import .SymbolicUnits:
     SymbolicDimensionsSingleton, SYMBOLIC_UNIT_VALUES, update_symbolic_unit_values!
@@ -14,7 +13,6 @@ function update_all_values(name_symbol, unit)
     ALL_MAPPING[name_symbol] = INDEX_TYPE(length(ALL_MAPPING) + 1)
 end
 
-
 # Register
 macro register_unit(name, value)
     return esc(_register_unit(name, value))
@@ -23,11 +21,13 @@ end
 function _register_unit(name::Symbol, value)
     name_symbol = Meta.quot(name)
     reg_expr = _lazy_register_unit(name, value)
-    push!(reg_expr.args, quote
-        $update_unit_mapping($name_symbol, $value)
-        $update_all_values($name_symbol, $value)
-        $update_symbolic_unit_values!($name_symbol)
-    end)
-    reg_expr
+    push!(reg_expr.args,
+        quote
+            $update_unit_mapping($name_symbol, $value)
+            $update_all_values($name_symbol, $value)
+            $update_symbolic_unit_values!($name_symbol)
+        end
+    )
+    return reg_expr
 end
 

src/symbolic_dimensions.jl

@@ -90,7 +90,7 @@ end
 function SymbolicDimensionsSingleton{R}(s::Symbol) where {R}
     i = get(ALL_MAPPING, s, INDEX_TYPE(0))
     iszero(i) && error("$s is not available as a symbol in `SymbolicDimensionsSingleton`. Symbols available: $(ALL_SYMBOLS).")
-    SymbolicDimensionsSingleton{R}(i)
+    return SymbolicDimensionsSingleton{R}(i)
 end
 
 # Traits:
@@ -367,15 +367,14 @@ to enable pretty-printing of units.
 """
 module SymbolicUnits
 
-
     import ..UNIT_SYMBOLS
     import ..CONSTANT_SYMBOLS
     import ..SymbolicDimensionsSingleton
-    import ...constructorof
-    import ...DEFAULT_SYMBOLIC_QUANTITY_TYPE
-    import ...DEFAULT_SYMBOLIC_QUANTITY_OUTPUT_TYPE
-    import ...DEFAULT_VALUE_TYPE
-    import ...DEFAULT_DIM_BASE_TYPE
+    import ..DEFAULT_SYMBOLIC_QUANTITY_TYPE
+    import ..constructorof
+    import ..DEFAULT_SYMBOLIC_QUANTITY_OUTPUT_TYPE
+    import ..DEFAULT_VALUE_TYPE
+    import ..DEFAULT_DIM_BASE_TYPE
 
     # Lazily create unit symbols (since there are so many)
     module Constants
@@ -393,9 +392,7 @@ module SymbolicUnits
             @eval begin
                 const $unit = constructorof(DEFAULT_SYMBOLIC_QUANTITY_TYPE)(
                     DEFAULT_VALUE_TYPE(1.0),
-                    SymbolicDimensionsSingleton{DEFAULT_DIM_BASE_TYPE}(
-                        $(QuoteNode(disambiguate_symbol(unit))),
-                    ),
+                    SymbolicDimensionsSingleton{DEFAULT_DIM_BASE_TYPE}($(QuoteNode(disambiguate_symbol(unit))))
                 )
                 push!(_SYMBOLIC_CONSTANT_VALUES, $unit)
             end
@@ -412,7 +409,7 @@ module SymbolicUnits
         @eval begin
             const $unit = constructorof(DEFAULT_SYMBOLIC_QUANTITY_TYPE)(
                 DEFAULT_VALUE_TYPE(1.0),
-                SymbolicDimensionsSingleton{DEFAULT_DIM_BASE_TYPE}($(QuoteNode(unit))),
+                SymbolicDimensionsSingleton{DEFAULT_DIM_BASE_TYPE}($(QuoteNode(unit)))
             )
             push!($symbolic_unit_values, $unit)
         end

test/runtests.jl

@@ -19,6 +19,9 @@ else
     @safetestset "Measurements.jl integration tests" begin
         include("test_measurements.jl")
     end
+    @safetestset "Meshes.jl integration tests" begin
+        include("test_meshes.jl")
+    end
     @safetestset "Unit tests" begin
         include("unittests.jl")
     end

test/unittests.jl

@@ -688,8 +688,8 @@ end
         @test !iszero(sym)
     end
 
-            q = 1.5us"km/s"
-            @test q == 1.5 * us"km" / us"s"
+    q = 1.5us"km/s"
+    @test q == 1.5 * us"km" / us"s"
     @test typeof(q) <: with_type_parameters(DEFAULT_QUANTITY_TYPE, Float64, SymbolicDimensions{DEFAULT_DIM_BASE_TYPE})
     @test string(dimension(q)) == "s⁻¹ km"
     @test uexpand(q) == 1.5u"km/s"