Merge pull request #172 from SymbolicML/fix-affine-promotion

fix: affine unit promotion in ustrip

Author: MilesCranmer

src/affine_dimensions.jl

@@ -131,6 +131,13 @@ julia> ustrip(ua"degF", 300u"K")
 ```
 """
 function ustrip(unit::AffineUnit, q::UnionAbstractQuantity)
-    unit.basedim == dimension(q) || throw(DimensionError(unit, q))
-    return (ustrip(q) - unit.offset) / unit.scale
+    q_promoted = _promote_quantity_for_affine(unit, q)
+    unit.basedim == dimension(q_promoted) || throw(DimensionError(unit, q_promoted))
+    return (ustrip(q_promoted) - unit.offset) / unit.scale
+end
+
+function _promote_quantity_for_affine(unit::AffineUnit, q::UnionAbstractQuantity{T,D}) where {T,D}
+    D_new = promote_type(D, typeof(unit.basedim))
+    Q_new = with_type_parameters(typeof(q), T, D_new)
+    return convert(Q_new, q)
 end

test/unittests.jl

@@ -2098,6 +2098,10 @@ end
     @test ustrip(ua"degC", 22ua"degC") ≈ 22.0
     @test ustrip(ua"degF", 22ua"degC") ≈ 71.6
     @test_throws DimensionError ustrip(ua"degC", 1.0u"m")
+
+    # Test symbolic units with ustrip
+    @test ustrip(ua"degC", 273.15us"K") ≈ 0.0
+    @test ustrip(ua"degC", 55us"K") ≈ -218.15
 end
 
 @testset "Test div" begin