Reduce unnecessary methods

Author: MilesCranmer

src/disambiguities.jl

@@ -52,6 +52,18 @@ for type in (Signed, Float64, Float32, Rational), op in (:flipsign, :copysign)
         return $(op)(x, ustrip(y))
     end
 end
+function Base.:*(l::Complex, r::AbstractRealQuantity)
+    new_quantity(typeof(r), l * ustrip(r), dimension(r))
+end
+function Base.:*(l::AbstractRealQuantity, r::Complex)
+    new_quantity(typeof(l), ustrip(l) * r, dimension(l))
+end
+function Base.:/(l::Complex, r::AbstractRealQuantity)
+    new_quantity(typeof(r), l / ustrip(r), inv(dimension(r)))
+end
+function Base.:/(l::AbstractRealQuantity, r::Complex)
+    new_quantity(typeof(l), ustrip(l) / r, dimension(l))
+end
 function Base.:*(l::Complex{Bool}, r::AbstractRealQuantity)
     return new_quantity(typeof(r), l * ustrip(r), dimension(r))
 end

src/math.jl

@@ -51,24 +51,6 @@ for (type, base_type, _) in ABSTRACT_QUANTITY_TYPES
     end
 end
 
-# Complex multiplication
-for (type, _, _) in ABSTRACT_QUANTITY_TYPES
-    @eval begin
-        function Base.:*(l::Complex, r::$type)
-            new_quantity(typeof(r), l * ustrip(r), dimension(r))
-        end
-        function Base.:*(l::$type, r::Complex)
-            new_quantity(typeof(l), ustrip(l) * r, dimension(l))
-        end
-        function Base.:/(l::Complex, r::$type)
-            new_quantity(typeof(r), l / ustrip(r), inv(dimension(r)))
-        end
-        function Base.:/(l::$type, r::Complex)
-            new_quantity(typeof(l), ustrip(l) / r, dimension(l))
-        end
-    end
-end
-
 Base.:*(l::AbstractDimensions, r::AbstractDimensions) = map_dimensions(+, l, r)
 Base.:/(l::AbstractDimensions, r::AbstractDimensions) = map_dimensions(-, l, r)