fix savefig issues

Author: sglyon

src/kaleido.jl

@@ -68,6 +68,8 @@ function _start_kaleido_process()
     nothing
 end
 
+savefig(p::SyncPlot; kwargs...) = savefig(p.plot; kwargs...)
+
 function savefig(
         p::Plot;
         width::Union{Nothing,Int}=nothing,
@@ -119,6 +121,10 @@ function savefig(
     end
 end
 
+
+@inline _get_Plot(p::Plot) = p
+@inline _get_Plot(p::SyncPlot) = p.plot
+
 """
     savefig(
         io::IO,
@@ -136,21 +142,20 @@ image scale. `width` and `height` set the dimensions, in pixels. Defaults
 are taken from `p.layout`, or supplied by plotly
 """
 function savefig(io::IO,
-        p::Plot;
+        p::Union{SyncPlot,Plot};
         width::Union{Nothing,Int}=nothing,
         height::Union{Nothing,Int}=nothing,
         scale::Union{Nothing,Real}=nothing,
         format::String="png")
-
-
     if format == "html"
-        return show(io, MIME("text/html"), p, include_mathjax="cdn", include_plotlyjs="cdn", full_html=true)
+        return show(io, MIME("text/html"), _get_Plot(p), include_mathjax="cdn", include_plotlyjs="cdn", full_html=true)
     end
 
     bytes = savefig(p, width=width, height=height, scale=scale, format=format)
     write(io, bytes)
 end
 
+
 """
     savefig(
         p::Plot, fn::AbstractString;
@@ -167,7 +172,7 @@ image scale. `width` and `height` set the dimensions, in pixels. Defaults
 are taken from `p.layout`, or supplied by plotly
 """
 function savefig(
-        p::Plot, fn::AbstractString;
+        p::Union{SyncPlot,Plot}, fn::AbstractString;
         format::Union{Nothing,String}=nothing,
         width::Union{Nothing,Int}=nothing,
         height::Union{Nothing,Int}=nothing,

test/kaleido.jl

@@ -1,17 +1,20 @@
-function myplot(fn)
+function myplot(fn, func)
     x = 0:0.1:2π
-    plt = Plot(scatter(x=x, y=sin.(x)))
+    plt = func(scatter(x=x, y=sin.(x)))
     savefig(plt, fn)
 end
 
 @testset "kaleido" begin
-    for ext in [PlotlyBase.ALL_FORMATS..., "html"]
-        if ext === "eps"
-            continue
+    for func in [Plot, plot]
+        for ext in [PlotlyJS.ALL_FORMATS..., "html"]
+            if ext === "eps"
+                continue
+            end
+            fn = tempname() * "." * ext
+            @show func, fn
+            myplot(fn, func) == fn
+            @test isfile(fn)
+            rm(fn)
         end
-        @show fn = tempname() * "." * ext
-        myplot(fn) == fn
-        @test isfile(fn)
-        rm(fn)
     end
 end