Skip to content

Commit c7ea4bb

Browse files
authored
Merge pull request #402 from JuliaPlots/nostyledocs
remove styles from docs as they are not supported anymore
2 parents 289fe1f + f837a34 commit c7ea4bb

File tree

5 files changed

+15
-292
lines changed

5 files changed

+15
-292
lines changed

docs/make.jl

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ using Random, Dates, LinearAlgebra, DelimitedFiles
1010

1111
# to override display_dict below
1212
import Documenter.Utilities: display_dict, limitstringmime
13-
using Base64: stringmime
13+
using Base64:stringmime
1414

1515
function display_dict(p::PlotlyBase.Plot)
1616
out = Dict{MIME,Any}()
@@ -39,7 +39,7 @@ function single_example_file(filename::String)
3939

4040
# Read lines from a files
4141
fulltext = open(
42-
f->read(f, String),
42+
f -> read(f, String),
4343
joinpath(THIS_DIR, "..", "examples", filename),
4444
"r"
4545
)
@@ -55,19 +55,19 @@ function single_example_file(filename::String)
5555
else
5656
first_line = findfirst(x -> match(regex, x) !== nothing, all_lines)
5757
if first_line !== nothing
58-
preamble = strip(join(all_lines[1:first_line-1], "\n"))
58+
preamble = strip(join(all_lines[1:first_line - 1], "\n"))
5959
write_example(preamble)
6060
end
6161
end
6262

6363
while true
6464
# Find next function name (break if none)
65-
l = findnext(x -> match(regex, x) !== nothing, all_lines, l+1)
65+
l = findnext(x -> match(regex, x) !== nothing, all_lines, l + 1)
6666
if l == 0 || l === nothing
6767
break
6868
end
6969
# find corresponding end for this function
70-
end_l = findnext(x -> match(regex_end, x) !== nothing, all_lines, l+1)
70+
end_l = findnext(x -> match(regex_end, x) !== nothing, all_lines, l + 1)
7171

7272
# Pull out function text
7373
func_block = join(all_lines[l:end_l], "\n")
@@ -98,22 +98,21 @@ end
9898
handle_examples()
9999

100100
makedocs(
101-
sitename = "PlotlyJS",
102-
format = Documenter.HTML(
103-
assets = [
101+
sitename="PlotlyJS",
102+
format=Documenter.HTML(
103+
assets=[
104104
asset("https://cdn.plot.ly/plotly-1.54.7.js")
105105
]
106106
),
107-
modules = [PlotlyJS, PlotlyBase],
107+
modules=[PlotlyJS, PlotlyBase],
108108
linkcheck=true,
109-
pages = [
109+
pages=[
110110
"Home" => "index.md",
111111
"User Guide" => [
112112
"Preliminaries" => "basics.md",
113113
"Building Blocks" => "building_traces_layouts.md",
114114
"Putting it together" => "syncplots.md",
115115
"Working with plots" => "manipulating_plots.md",
116-
"Styles" => "styles.md",
117116
"Contributing" => "contributing.md",
118117
],
119118
"Examples" => [
@@ -141,10 +140,10 @@ makedocs(
141140
# Documenter can also automatically deploy documentation to gh-pages.
142141
# See "Hosting Documentation" and deploydocs() in the Documenter manual
143142
# for more information.
144-
#=deploydocs(
143+
#= deploydocs(
145144
repo = "<repository url>"
146-
)=#
145+
) =#
147146

148147
deploydocs(
149-
repo = "github.com/JuliaPlots/PlotlyJS.jl.git",
148+
repo="github.com/JuliaPlots/PlotlyJS.jl.git",
150149
)

docs/src/basics.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,14 +54,11 @@ mutable struct Plot{TT<:AbstractVector{<:AbstractTrace},TL<:AbstractLayout,TF<:A
5454
divid::UUID
5555
config::PlotConfig
5656
frames::TF
57-
style::Style
5857
end
5958
```
6059

6160
The `data`, `layout`, `divid`, `config`, and `frames` fields of the `Plot` type map 1-1 to the arguments to the `Plotly.newplot` function.
6261

63-
The `style` argument is unique to Julia and hooks into the Julia based themeing and styling system as described in [the style docs](@ref styles)
64-
6562

6663
[_plotlyjs]: https://plotly.com/javascript/
6764
[_plotlyref]: https://plotly.com/julia/reference/

docs/src/examples/violin.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ violin_side_by_side()
129129
```
130130

131131
```@example violin
132-
function violin_style()
132+
function violin_styled()
133133
y1 = vcat(abs.(20 .* rand(100)), rand(UInt16, 300) .* 500 ./ typemax(UInt16))
134134
y2 = [25.261999999999997, 66.5419, 98.2114, 0.09070629 ]
135135
box = attr(fillcolor="black", line_color="black", width=0.01)
@@ -157,6 +157,6 @@ function violin_style()
157157
)
158158
plot([trace1, trace2], layout)
159159
end
160-
violin_style()
160+
violin_styled()
161161
```
162162

docs/src/styles.md

Lines changed: 0 additions & 272 deletions
This file was deleted.

docs/src/syncplots.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ mutable struct Plot{TT<:AbstractVector{<:AbstractTrace},TL<:AbstractLayout,TF<:A
1919
frames::TF
2020
divid::UUID
2121
config::PlotConfig
22-
style::Style
2322
end
2423
```
2524

0 commit comments

Comments
 (0)