fix: prevent namespace pollution bug (master) (#5171)

* fix: prevent namespace pollution bug

* chore: zenodo entry

* chore: IIFE to avoid polluting ijulia's js namespace

* chore: fix the id again

* Update plotly.jl

---------

Co-authored-by: t-bltg <[email protected]>

Author: pankgeorg

.zenodo.json

@@ -791,6 +791,11 @@
             "name": "James Wrigley",
             "orcid": "0009-0003-6525-7413",
             "type": "Other"
+        },
+        {
+            "affiliation": "@JuliaComputing",
+            "name": "Παναγιώτης Γεωργακόπουλος",
+            "type": "Other"
         }
     ],
     "upload_type": "software"

src/backends/plotly.jl

@@ -1108,17 +1108,24 @@ function plotly_html_body(plt, style = nothing)
         requirejs_suffix = "});"
     end
 
-    unique_tag = replace(string(UUIDs.uuid4()), '-' => '_')
+    unique_tag = "id_$(replace(string(UUIDs.uuid4()), '-' => '_'))"
+
     html = """
         <div id=\"$unique_tag\" style=\"$style\"></div>
         <script>
+        ;(()=> {
         function plots_jl_plotly_$unique_tag() {
             $(requirejs_prefix)
             $(js_body(plt, unique_tag))
             $(requirejs_suffix)
         }
+        let plotlyloader = window.document.createElement("script")
+        let src="https://requirejs.org/docs/release/$(Plots._requirejs_version)/minified/require.js"
+        plotlyloader.addEventListener("load", plots_jl_plotly_$unique_tag);
+        plotlyloader.src = src
+        document.querySelector("#$unique_tag").appendChild(plotlyloader)
+        })()
         </script>
-        <script src="https://requirejs.org/docs/release/$_requirejs_version/minified/require.js" onload="plots_jl_plotly_$unique_tag()"></script>
     """
     return html
 end