Merge branch 'more-linalg2' of github.com:asmeurer/array-api-tests into more-linalg2

Author: asmeurer

array_api_tests/array_helpers.py

@@ -171,7 +171,7 @@ def allclose(x, y, rel_tol=0.25, abs_tol=1, return_indices=False):
             return False
     return True
 
-def assert_allclose(x, y, rel_tol=0.25, abs_tol=1):
+def assert_allclose(x, y, rel_tol=1, abs_tol=0.):
     """
     Test that x and y are approximately equal to each other.
 

array_api_tests/test_linalg.py

@@ -250,10 +250,18 @@ def test_eigh(x):
     assert eigenvectors.dtype == x.dtype, "eigh().eigenvectors did not return the correct dtype"
     assert eigenvectors.shape == x.shape, "eigh().eigenvectors did not return the correct shape"
 
+    # The order of the eigenvectors is not specified, so make sure the same
+    # eigenvectors are compared against each other.
     _test_stacks(lambda x: linalg.eigh(x).eigenvalues, x,
-                 res=eigenvalues, dims=1)
-    _test_stacks(lambda x: linalg.eigh(x).eigenvectors, x,
-                 res=eigenvectors, dims=2)
+                 res=eigenvalues, dims=1, assert_equal=lambda a, b:
+                 assert_equal(xp.sort(a), xp.sort(b)))
+
+    # There are equivalent ways of representing eigenvectors, and algorithms
+    # may not give the same eigenvectors on a stack vs. a matrix.
+    # TODO: Test that eigenvectors are orthonormal.
+
+    # _test_stacks(lambda x: linalg.eigh(x).eigenvectors, x,
+    #              res=eigenvectors, dims=2)
 
     # TODO: Test that res actually corresponds to the eigenvalues and
     # eigenvectors of x