Skip to content

Commit 241220e

Browse files
committed
Disable eigenvectors stack test
There are different equivalent ways of representing eigenspaces in general, and the same algorithm may choose different ways for stacked vs. non-stacked matrices (e.g., they differ for cupy).
1 parent 9bb8c7a commit 241220e

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

array_api_tests/test_linalg.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -253,8 +253,13 @@ def test_eigh(x):
253253

254254
_test_stacks(lambda x: linalg.eigh(x).eigenvalues, x,
255255
res=eigenvalues, dims=1)
256-
_test_stacks(lambda x: linalg.eigh(x).eigenvectors, x,
257-
res=eigenvectors, dims=2)
256+
257+
# There are equivalent ways of representing eigenvectors, and algorithms
258+
# may not give the same eigenvectors on a stack vs. a matrix.
259+
# TODO: Test that eigenvectors are orthonormal.
260+
261+
# _test_stacks(lambda x: linalg.eigh(x).eigenvectors, x,
262+
# res=eigenvectors, dims=2)
258263

259264
# TODO: Test that res actually corresponds to the eigenvalues and
260265
# eigenvectors of x

0 commit comments

Comments
 (0)