Skip to content

Commit cd77e3b

Browse files
author
Frankie Robertson
committed
Fix spelling error Criteron => Criterion
1 parent 832b863 commit cd77e3b

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

src/NextItemRules/NextItemRules.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ export PointResponseExpectation, DistributionResponseExpectation
5656
export MatrixScalarizer, DeterminantScalarizer, TraceScalarizer
5757
export AbilityCovarianceStateMultiCriterion, StateMultiCriterion, ItemMultiCriterion
5858
export InformationMatrixCriteria
59-
export ScalarizedStateCriteron, ScalarizedItemCriteron
59+
export ScalarizedStateCriterion, ScalarizedItemCriterion
6060
export DRuleItemCriterion, TRuleItemCriterion
6161

6262
# Prelude

src/NextItemRules/combinators/scalarizers.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,23 +4,23 @@ scalarize(::DeterminantScalarizer, mat) = det(mat)
44
struct TraceScalarizer <: MatrixScalarizer end
55
scalarize(::TraceScalarizer, mat) = tr(mat)
66

7-
struct ScalarizedItemCriteron{
7+
struct ScalarizedItemCriterion{
88
ItemMultiCriterionT <: ItemMultiCriterion,
99
MatrixScalarizerT <: MatrixScalarizer
1010
} <: ItemCriterion
1111
criteria::ItemMultiCriterionT
1212
scalarizer::MatrixScalarizerT
1313
end
1414

15-
struct ScalarizedStateCriteron{
15+
struct ScalarizedStateCriterion{
1616
StateMultiCriterionT <: StateMultiCriterion,
1717
MatrixScalarizerT <: MatrixScalarizer
1818
} <: StateCriterion
1919
criteria::StateMultiCriterionT
2020
scalarizer::MatrixScalarizerT
2121
end
2222

23-
function compute_criterion(ssc::Union{ScalarizedItemCriteron, ScalarizedStateCriteron},
23+
function compute_criterion(ssc::Union{ScalarizedItemCriterion, ScalarizedStateCriterion},
2424
tracked_responses::TrackedResponses, item_idx...)
2525
res = scalarize(
2626
ssc.scalarizer,
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
function DRuleItemCriterion(ability_estimator)
2-
ScalarizedItemCriteron(
2+
ScalarizedItemCriterion(
33
InformationMatrixCriteria(ability_estimator),
44
DeterminantScalarizer())
55
end
66

77
function TRuleItemCriterion(ability_estimator)
8-
ScalarizedItemCriteron(
8+
ScalarizedItemCriterion(
99
InformationMatrixCriteria(ability_estimator),
1010
TraceScalarizer())
1111
end

test/ability_estimator_2d.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ mle_mode_2d = ModeAbilityEstimator(lh_est_2d, optimizer_2d)
6161

6262
@testset "2 dim information higher closer to current estimate" begin
6363
information_matrix_criteria = InformationMatrixCriteria(mle_mean_2d)
64-
information_criterion = ScalarizedItemCriteron(
64+
information_criterion = ScalarizedItemCriterion(
6565
information_matrix_criteria, DeterminantScalarizer())
6666

6767
# Item closer to the current estimate (1, 1)
@@ -79,7 +79,7 @@ mle_mode_2d = ModeAbilityEstimator(lh_est_2d, optimizer_2d)
7979
@testset "2 dim variance smaller closer to current estimate" begin
8080
covariance_state_criterion = AbilityCovarianceStateMultiCriterion(
8181
lh_est_2d, integrator_2d)
82-
variance_criterion = ScalarizedStateCriteron(
82+
variance_criterion = ScalarizedStateCriterion(
8383
covariance_state_criterion, DeterminantScalarizer())
8484
variance_item_criterion = ExpectationBasedItemCriterion(
8585
mle_mean_2d, variance_criterion)
@@ -99,7 +99,7 @@ mle_mode_2d = ModeAbilityEstimator(lh_est_2d, optimizer_2d)
9999
@testset "2 dim variance is whack with trace scalarizer" begin
100100
covariance_state_criterion = AbilityCovarianceStateMultiCriterion(
101101
lh_est_2d, integrator_2d)
102-
variance_criterion = ScalarizedStateCriteron(
102+
variance_criterion = ScalarizedStateCriterion(
103103
covariance_state_criterion, TraceScalarizer())
104104
variance_item_criterion = ExpectationBasedItemCriterion(
105105
mle_mean_2d, variance_criterion)

0 commit comments

Comments
 (0)