Skip to content

Commit ddfd3ea

Browse files
authored
Expand precompilation (#1015)
* Create expanded precompilation * Expand conversions for precompile * Precompile more types * Add calls from running `runtests.jl` * Remove overly-specific precompile statements * `Core.TypeofVarargs` requires newer Julia * Require Julia >= 1.4 * Remove Julia 1.0 test
1 parent 38b1061 commit ddfd3ea

File tree

4 files changed

+534
-12
lines changed

4 files changed

+534
-12
lines changed

.github/workflows/system.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ jobs:
2020
architecture: [x64]
2121
python-version: ['3.x']
2222
julia-version:
23-
- '1.0'
2423
- '1'
2524
- 'nightly'
2625
include:

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ VersionParsing = "81def892-9a0e-5fdd-b105-ffc91e053289"
1616
Conda = "1.0"
1717
MacroTools = "0.4, 0.5"
1818
VersionParsing = "1.0"
19-
julia = "0.7, 1.0"
19+
julia = "1.4"
2020

2121
[extras]
2222
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

src/PyCall.jl

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -980,16 +980,8 @@ include("serialize.jl")
980980
include("pyinit.jl")
981981

982982
#########################################################################
983-
# Precompilation: just an optimization to speed up initialization.
984-
# Here, we precompile functions that are passed to cfunction by __init__,
985-
# for the reasons described in JuliaLang/julia#12256.
986983

987-
precompile(pyjlwrap_call, (PyPtr,PyPtr,PyPtr))
988-
precompile(pyjlwrap_dealloc, (PyPtr,))
989-
precompile(pyjlwrap_repr, (PyPtr,))
990-
precompile(pyjlwrap_hash, (PyPtr,))
991-
precompile(pyjlwrap_hash32, (PyPtr,))
992-
993-
# TODO: precompilation of the io.jl functions
984+
include("precompile.jl")
994985

986+
#########################################################################
995987
end # module PyCall

0 commit comments

Comments
 (0)