Skip to content

Commit 2ab39a4

Browse files
author
Christopher Doris
committed
Remove unused _pyjlbase_as_buffer constant
Buffer protocol methods are now handled through PyType_Slot mechanism, making the old _pyjlbase_as_buffer constant unnecessary.
1 parent 5323048 commit 2ab39a4

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

pysrc/juliacall/juliapkg.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@
33
"packages": {
44
"PythonCall": {
55
"uuid": "6099a3de-0909-46bc-b1f4-468b9a2dfc0d",
6-
"version": "=0.9.26"
6+
"version": "=0.9.26",
7+
"path": "../..",
8+
"dev": true
79
},
810
"OpenSSL_jll": {
911
"uuid": "458c3c95-2e84-50aa-8efc-19380b2a3a95",

src/JlWrap/C.jl

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,6 @@ const _pyjlbase_deserialize_name = "_jl_deserialize"
277277
const _pyjlbase_weaklistoffset_name = "__weaklistoffset__"
278278
const _pyjlbase_methods = Vector{C.PyMethodDef}()
279279
const _pyjlbase_members = Vector{C.PyMemberDef}()
280-
const _pyjlbase_as_buffer = fill(C.PyBufferProcs())
281280
const _pyjlbase_slots = Vector{C.PyType_Slot}()
282281
const _pyjlbase_spec = fill(C.PyType_Spec())
283282

@@ -312,10 +311,6 @@ function init_c()
312311
),
313312
C.PyMethodDef(),
314313
)
315-
_pyjlbase_as_buffer[] = C.PyBufferProcs(
316-
get = @cfunction(_pyjl_get_buffer, Cint, (C.PyPtr, Ptr{C.Py_buffer}, Cint)),
317-
release = @cfunction(_pyjl_release_buffer, Cvoid, (C.PyPtr, Ptr{C.Py_buffer})),
318-
)
319314

320315
# Create members for weakref support
321316
empty!(_pyjlbase_members)

0 commit comments

Comments
 (0)