Merge pull request #4076 from JuliaReach/schillic/tests

Revise tolerance tests and comments

Author: schillic

test/Sets/Interval.jl

@@ -529,6 +529,7 @@ for N in @tN([Float64, Float32, Rational{Int}])
         # TODO ∈ and isdisjoint should be consistent
         @test_broken !res && w isa Vector{N} && w ∈ X && w ∈ Y
         r = LazySets._rtol(N)
+        @assert r > N(1e-10) "default tolerance changed; adapt test"
         LazySets.set_rtol(N, N(1e-10))
         @test isdisjoint(X, Y)
         res, w = isdisjoint(X, Y, true)

test/Sets/LineSegment.jl

@@ -40,10 +40,11 @@ for N in @tN([Float64, Float32, Rational{Int}])
 
     # approximate membership test
     if N == Float64
-        @test N[1.5, 1.5] ∈ LineSegment(N[1.5, 1.50000000000001], N[1.5, 2.0])
+        @test N[1.5, 1.5] ∈ LineSegment(N[1.5, 1.500000001], N[1.5, 2.0])
         r = LazySets._rtol(N)
-        LazySets.set_rtol(N, N(1e-20))
-        @test !(N[1.5, 1.5] ∈ LineSegment(N[1.5, 1.50000000000001], N[1.5, 2.0]))
+        @assert r > N(1e-10) "default tolerance changed; adapt test"
+        LazySets.set_rtol(N, N(1e-10))
+        @test N[1.5, 1.5] ∉ LineSegment(N[1.5, 1.500000001], N[1.5, 2.0])
         LazySets.set_rtol(N, r)
     end
 

test/Sets/Zonotope.jl

@@ -432,7 +432,7 @@ for N in @tN([Float64, Float32, Rational{Int}])
     @test isidentical(Z2, Zonotope(N[4, 5, 6], N[3 7; 3 7; 3 7]))
 
     # distance (between point and set)
-    @test_broken distance(Z, N[0, 0]) isa LazySet{N}  # TODO this should work
+    @test_broken distance(Z, N[0, 0]) isa LazySet{N}  # TODO implement `distance` for polytopes
     # @test_throws DimensionMismatch distance(Z, N[0])
     # @test_throws ArgumentError distance(Z, N[0]; p=N(1 // 2))
     # for (x, v) in ((N[1], N(0)), (N[4], N(2)))
@@ -606,10 +606,10 @@ for N in @tN([Float64, Float32, Rational{Int}])
     end
 
     # difference
-    @test_broken difference(Z, Z3) isa LazySet{N}  # TODO this should work (add more tests later)
+    @test_broken difference(Z, Z3) isa LazySet{N}  # TODO implement `difference` for polytopes (add more tests later)
 
     # distance (between two sets)
-    @test_broken distance(Z, Z3) isa LazySet{N}  # TODO this should work (add more tests later)
+    @test_broken distance(Z, Z3) isa LazySet{N}  # TODO implement `distance` for polytopes (add more tests later)
 
     # exact_sum
     @test_throws DimensionMismatch exact_sum(Z, Z3)
@@ -662,8 +662,9 @@ for N in @tN([Float64, Float32, Rational{Int}])
         Z2 = Zonotope(N[6 + 1e-9, 8], N[1 0; 0 1])
         @test !isdisjoint(Z, Z2)
         r = LazySets._rtol(N)
+        @assert r > N(1e-10) "default tolerance changed; adapt test"
         LazySets.set_rtol(N, N(1e-10))
-        @test_broken isdisjoint(Z, Z2)  # TODO this should work
+        @test_broken isdisjoint(Z, Z2)  # cannot adapt tolerance of LP solver
         # restore tolerance
         LazySets.set_rtol(N, r)
     end
@@ -705,8 +706,8 @@ for N in @tN([Float64, Float32, Rational{Int}])
 
     # linear_combination
     @test_throws DimensionMismatch linear_combination(Z, Z3)
-    @test_broken linear_combination(Z, Xnc)  # TODO implement `linear_combination` for non-convex sets
-    @test_broken linear_combination(Xnc, Z)
+    @test_broken linear_combination(Z, Xnc) isa LazySet{N}  # TODO implement `linear_combination` for non-convex sets
+    @test_broken linear_combination(Xnc, Z) isa LazySet{N}
     for X in (linear_combination(Z, Z), linear_combination(Z, P), linear_combination(P, Z))
         @test X isa LazySet{N} && isequivalent(X, Z)
     end