Merge pull request #352 from JuliaReach/schillic/ExplicitImports

Use ExplicitImports in tests and fix import issues

Author: schillic

src/MathematicalSystems.jl

@@ -1,8 +1,9 @@
 module MathematicalSystems
 
-using LinearAlgebra, SparseArrays
-using LinearAlgebra: checksquare
-import RecipesBase
+using Base: /
+using LinearAlgebra: LinearAlgebra, Adjoint, Diagonal, I, Transpose,
+                     UniformScaling, checksquare, rank
+using SparseArrays: sparsevec, spzeros
 using RecipesBase: @recipe
 using Espresso: matchex
 using MacroTools: @capture

src/init.jl

@@ -1,6 +1,6 @@
 # optional dependencies
 @static if !isdefined(Base, :get_extension)
-    using Requires
+    using Requires: @require
 end
 
 @static if !isdefined(Base, :get_extension)

test/Aqua.jl

@@ -1,5 +1,6 @@
 [deps]
 Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
+ExplicitImports = "7d51a73a-1435-4ff3-83d9-f097790105c7"
 InteractiveUtils = "b77e0a4c-d291-57a0-90e8-8db25a27a240"
 LazySets = "b4f0291d-fe17-52bc-9479-3d1a343d9043"
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
@@ -10,6 +11,7 @@ TypedPolynomials = "afbbf031-7a57-5f58-a1b9-b774a0fad08d"
 
 [compat]
 Aqua = "0.8.9"
+ExplicitImports = "1"
 LazySets = "5"
 RecipesBase = "1"
 TypedPolynomials = "0.3, 0.4"

test/Project.toml

@@ -0,0 +1,26 @@
+using MathematicalSystems, Test
+import Aqua, ExplicitImports
+
+@testset "ExplicitImports tests" begin
+    ignores = (:checksquare,)
+    @test isnothing(ExplicitImports.check_all_explicit_imports_are_public(MathematicalSystems;
+                                                                          ignore=ignores))
+    @test isnothing(ExplicitImports.check_all_explicit_imports_via_owners(MathematicalSystems))
+    ignores = (:AbstractRotation, :IsInfinite, :typename, :parse,
+               :AbstractTriangular, :IteratorSize)
+    @test isnothing(ExplicitImports.check_all_qualified_accesses_are_public(MathematicalSystems;
+                                                                            ignore=ignores))
+    @test isnothing(ExplicitImports.check_all_qualified_accesses_via_owners(MathematicalSystems))
+    @test isnothing(ExplicitImports.check_no_implicit_imports(MathematicalSystems))
+    @test isnothing(ExplicitImports.check_no_self_qualified_accesses(MathematicalSystems))
+    ignores = (:LinearParametricContinuousSystem,
+               :LinearParametricDiscreteSystem,
+               :LinearControlParametricContinuousSystem,
+               :LinearControlParametricDiscreteSystem)  # false positives due to meta-programming
+    @test isnothing(ExplicitImports.check_no_stale_explicit_imports(MathematicalSystems;
+                                                                    ignore=ignores))
+end
+
+@testset "Aqua tests" begin
+    Aqua.test_all(MathematicalSystems)
+end

test/quality_assurance.jl

@@ -67,4 +67,4 @@ end
     include("macros.jl")
 end
 
-include("Aqua.jl")
+include("quality_assurance.jl")