Skip to content

Commit 3739710

Browse files
authored
Merge pull request #336 from JuliaReach/schillic/version
Bump minimal Julia version to v1.6
2 parents 5862eec + 2ac13fa commit 3739710

File tree

3 files changed

+18
-5
lines changed

3 files changed

+18
-5
lines changed

.github/workflows/test-pull-request.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
arch:
2727
- x64
2828
include:
29-
- version: '1.5' # test on oldest supported version
29+
- version: '1.6' # test on oldest supported version
3030
arch: x64
3131
os: ubuntu-latest
3232
env:

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,4 @@ MultivariatePolynomials = "0.3, 0.4, 0.5"
2121
RecipesBase = "0.6, 0.7, 0.8, 1.0, 1.1, 1.2"
2222
Requires = "1.3.1"
2323
SparseArrays = "<0.0.1, 1.4"
24-
julia = "1.5"
24+
julia = "1.6"

src/identity.jl

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -101,9 +101,22 @@ function Base.:(*)(𝐼::IdentityMultiple, v::AbstractVector)
101101
end
102102

103103
# beside `AbstractMatrix`, we need some disambiguations with LinearAlgebra since v1.6
104-
for M in @static VERSION < v"1.6" ? [:AbstractMatrix] :
105-
(:AbstractMatrix, :Diagonal, :(Transpose{<:Any,<:AbstractVector}),
106-
:(Adjoint{<:Any,<:AbstractVector}), :(LinearAlgebra.AbstractTriangular))
104+
MATRICES = @static VERSION < v"1.6" ? [:AbstractMatrix] :
105+
[:AbstractMatrix, :Diagonal, :(Transpose{<:Any,<:AbstractVector}),
106+
:(Adjoint{<:Any,<:AbstractVector}), :(LinearAlgebra.AbstractTriangular)]
107+
@static if VERSION < v"1.8"
108+
append!(MATRICES,
109+
[:(Transpose{<:Any,
110+
<:Union{LinearAlgebra.Hermitian{T,S},LinearAlgebra.Symmetric{T,S},
111+
LinearAlgebra.Symmetric{Complex{T},S}} where {T<:Real,S}}),
112+
:(Adjoint{<:Any,
113+
<:Union{LinearAlgebra.Hermitian{T,S},LinearAlgebra.Hermitian{Complex{T},S},
114+
LinearAlgebra.Symmetric{T,S}} where {T<:Real,S}})])
115+
end
116+
@static if VERSION < v"1.9"
117+
push!(MATRICES, :(Adjoint{<:Any,<:LinearAlgebra.AbstractRotation}))
118+
end
119+
for M in MATRICES
107120
@eval begin
108121
function Base.:(*)(𝐼::IdentityMultiple, A::$M)
109122
𝐼.n != size(A, 1) && throw(DimensionMismatch("incompatible dimensions"))

0 commit comments

Comments
 (0)