Skip to content

Commit 0db1882

Browse files
committed
If the entry has "=" then make a strict-version update
- bump_compat_containing_equality_specifier and strict_version should be true
1 parent 779bfb6 commit 0db1882

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

src/utilities/new_versions.jl

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ function new_compat_entry(::EntryType, old_compat::Nothing, new_compat::Abstract
2828
return "$(strip(new_compat))"
2929
end
3030

31-
function compat_version_number(ver::VersionNumber, strict_version::Bool=false)
32-
strict_version && return "= $(ver.major).$(ver.minor).$(ver.patch)"
31+
function compat_version_number(ver::VersionNumber, handle_equality_in_entries::Bool=false)
32+
handle_equality_in_entries && return "= $(ver.major).$(ver.minor).$(ver.patch)"
3333
(ver.major > 0) && return "$(ver.major)"
3434
(ver.minor > 0) && return "0.$(ver.minor)"
3535

@@ -221,7 +221,10 @@ function make_pr_for_new_version(
221221
end
222222

223223
# Get new compat entry version, pr title, and pr body text
224-
compat_entry_for_latest_version = compat_version_number(dep.latest_version, strict_version)
224+
handle_equality_in_entries = skip_equality_specifiers(
225+
bump_compat_containing_equality_specifier, dep.version_verbatim
226+
) && strict_version
227+
compat_entry_for_latest_version = compat_version_number(dep.latest_version, handle_equality_in_entries)
225228
brand_new_compat = new_compat_entry(
226229
entry_type, dep.version_verbatim, compat_entry_for_latest_version
227230
)

test/utilities/new_versions.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ end
7979
@test CompatHelper.compat_version_number(vn) == expected
8080
end
8181

82-
@testset "compat_version_number -- $(vn)" for (vn, expected) in [
82+
@testset "Strict compat_version_number -- $(vn)" for (vn, expected) in [
8383
(VersionNumber("1.0.0"), "= 1.0.0"),
8484
(VersionNumber("1.1.1"), "= 1.1.1"),
8585
(VersionNumber("1.1.0"), "= 1.1.0"),
@@ -88,8 +88,8 @@ end
8888
(VersionNumber("0.0.1"), "= 0.0.1"),
8989
(VersionNumber("0.0.0"), "= 0.0.0"),
9090
]
91-
strict_version=true
92-
@test CompatHelper.compat_version_number(vn, strict_version) == expected
91+
handle_equality_in_entries=true
92+
@test CompatHelper.compat_version_number(vn, handle_equality_in_entries) == expected
9393
end
9494
#=
9595
@testset "subdir_string -- $(subdir)" for (subdir, expected) in [

0 commit comments

Comments
 (0)