-
Notifications
You must be signed in to change notification settings - Fork 32
Open
Milestone
Description
Nice!
I have two short comments after a short first look: In the intro you introduce Lie groups – at the end you link to JuliaManifolds/Manifolds.jl, but you could actually link to the documentation about GroupManifolds? https://juliamanifolds.github.io/Manifolds.jl/latest/manifolds/group.html
Second, more e technical remark: We redesigned ManifoldsBase to have a neat trait system, so AbstractGroupManifold will vanish in the next (breaking) release of Manifolds.jl (based on the already released ManifoldsBase.jl 0.13.0 with its own documentation now) and there will just be a IsGroupManifold trait.
Oh I just saw two further things down the road:
- You write
$T_M(p)$ for the tangent space, we actually write$T_p\mathcal M$ (manifolds are calligraphic). This is just a remark, if you have a different notation that is fine of course, if you just use this notation in this one place, maybe it might be helpful to the reader to use only one notation. - you write
$vee$ . and$Euclidean$ and such in Math mode. To me that reads as variables multiplied (so it would acutally be$e^2v$ ), since they are in italics, the function would be$\mathrm{vee}$ (but that's also just me, a math and notation nerd).
Originally posted by @kellertuer in JuliaManifolds/Manifolds.jl#355 (comment)
Metadata
Metadata
Assignees
Type
Projects
Status
No status