Skip to content

Commit 0f5e982

Browse files
authored
Merge pull request #1344 from JuliaRobotics/21Q3/refac/consolsfparam
some cleanup
2 parents 67f213d + cccdecf commit 0f5e982

File tree

3 files changed

+8
-12
lines changed

3 files changed

+8
-12
lines changed

src/IncrementalInference.jl

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -284,16 +284,13 @@ export *,
284284
getParent,
285285
getCliqSiblings,
286286
getNumCliqs,
287-
getBelief, getKDE,
287+
getBelief,
288288
CliqStateMachineContainer,
289289

290290
solveCliqUp!,
291291
solveCliqDown!,
292292
fifoFreeze!,
293293

294-
# temp const types TODO
295-
TempUpMsgPlotting,
296-
297294
#functors need
298295
getSample,
299296
sampleFactor!,
@@ -310,7 +307,6 @@ export *,
310307
evalFactor,
311308
approxConvBelief,
312309
approxConv,
313-
approxConvBinary,
314310

315311
# more debugging tools
316312
localProduct,

test/priorusetest.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,8 +108,8 @@ l1_m = getKDEMean(getKDE(getVariable(fg, :l1)))[1]
108108
@test isapprox(x0_m, 0.0, atol = 1.0)
109109
@test isapprox(x1_m, 0.0, atol = 1.0)
110110
@test isapprox(x2_m, 0.0, atol = 1.0)
111-
@test isapprox(l0_m, 0.0, atol = 1.0)
112-
@test isapprox(l1_m, 0.0, atol = 1.0)
111+
@test isapprox(l0_m, 0.0, atol = 1.2)
112+
@test isapprox(l1_m, 0.0, atol = 1.2)
113113

114114
#testing if values are close to one another
115115
@show testvals = [x0_m, x1_m, x2_m, l0_m, l1_m]

test/testBasicGraphs.jl

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -286,23 +286,23 @@ X4 = (getBelief(fg, :x4) |> getKDEMean)[1]
286286

287287
pts_ = getPoints(getBelief(fg, :x0))
288288
TensorCast.@cast pts[i,j] := pts_[j][i]
289-
@test 0.2 < Statistics.cov( pts[1,:] ) < 2.3
289+
@test 0.2 < Statistics.cov( pts[1,:] ) < 2.8
290290

291291
pts_ = getPoints(getBelief(fg, :x1))
292292
TensorCast.@cast pts[i,j] := pts_[j][i]
293-
@test 0.2 < Statistics.cov( pts[1,:] ) < 2.4
293+
@test 0.2 < Statistics.cov( pts[1,:] ) < 2.9
294294

295295
pts_ = getPoints(getBelief(fg, :x2))
296296
TensorCast.@cast pts[i,j] := pts_[j][i]
297-
@test 0.2 < Statistics.cov( pts[1,:] ) < 2.6
297+
@test 0.2 < Statistics.cov( pts[1,:] ) < 3.0
298298

299299
pts_ = getPoints(getBelief(fg, :x3))
300300
TensorCast.@cast pts[i,j] := pts_[j][i]
301-
@test 0.2 < Statistics.cov( pts[1,:] ) < 2.7
301+
@test 0.2 < Statistics.cov( pts[1,:] ) < 3.1
302302

303303
pts_ = getPoints(getBelief(fg, :x4))
304304
TensorCast.@cast pts[i,j] := pts_[j][i]
305-
@test 0.2 < Statistics.cov( pts[1,:] ) < 2.8
305+
@test 0.2 < Statistics.cov( pts[1,:] ) < 3.2
306306

307307
@testset "Test localProduct on solveKey" begin
308308

0 commit comments

Comments
 (0)