Skip to content

Commit 4637ec6

Browse files
authored
rm getprop on cf.manifold (#1793)
1 parent 22dd738 commit 4637ec6

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

src/entities/CalcFactor.jl

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -121,13 +121,3 @@ _nvars(::CalcFactorResidual{FT, N, D, MEAS, L, C}) where {FT, N, D, MEAS, L, C}
121121
# _typeof_meas(::CalcFactorManopt{FT, C, D, L, MEAS, N}) where {FT, C, D, L, MEAS, N} = MEAS
122122
DFG.getDimension(::CalcFactorResidual{FT, N, D, MEAS, L, C}) where {FT, N, D, MEAS, L, C} = D
123123

124-
# workaround for issue #1781
125-
import Base: getproperty
126-
function Base.getproperty(cf::CalcFactor, f::Symbol)
127-
if f === :manifold
128-
# assumes constant propagation to avoid allocations in residual functions getManifold(factor)
129-
getManifold(cf.factor)
130-
else
131-
getfield(cf, f)
132-
end
133-
end

0 commit comments

Comments
 (0)