Skip to content

Commit 742daf1

Browse files
committed
fix solveFactorParametric as coordinates only
1 parent 5de4ee9 commit 742daf1

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

src/TetherUtils.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,7 @@ Notes
111111
- Not used during tree inference.
112112
- Expected uses are for user analysis of factors and estimates.
113113
- real-time dead reckoning chain prediction.
114+
- Returns mean value as coordinates
114115
115116
DevNotes
116117
- # TODO consolidate with similar `approxConv`

src/services/ApproxConv.jl

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -276,9 +276,13 @@ function solveFactorParameteric(dfg::AbstractDFG,
276276

277277
# get the measurement point
278278
fctTyp = getFactorType(fct)
279+
# this is definitely in coordinates, see JuliaRobotics/RoME.jl#465
279280
mea, _ = getMeasurementParametric(fctTyp)
280-
# should this be coords, tangent, or point
281-
measT = (mea,)
281+
# must change measT to be a tangent vector
282+
M = getManifold(fctTyp)
283+
e0 = identity_element(M)
284+
mea_ = hat(M, e0, mea)
285+
measT = (mea_,)
282286

283287
# get variable points
284288
function _getParametric(vari::DFGVariable, key=:default)

0 commit comments

Comments
 (0)