Merge pull request #1691 from JuliaRobotics/bug/dispatch_nosolverparams

Affie · web-flow · commit 81208459a20a · 2023-03-08T08:19:19.000+02:00
NoSolverParams does not have attemptGradients
diff --git a/src/Serialization/services/DispatchPackedConversions.jl b/src/Serialization/services/DispatchPackedConversions.jl
@@ -50,7 +50,10 @@ function reconstFactorData(
     certainhypo = packed.certainhypo,
     inflation = packed.inflation,
     userCache,
-    _blockRecursion=!getSolverParams(dfg).attemptGradients,
+    # Block recursion if NoSolverParams or if set to not attempt gradients.
+    _blockRecursion=
+      getSolverParams(dfg) isa NoSolverParams || 
+      !getSolverParams(dfg).attemptGradients,
   )
   #
 

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,10 @@ function reconstFactorData(`
`50`	`50`	`certainhypo = packed.certainhypo,`
`51`	`51`	`inflation = packed.inflation,`
`52`	`52`	`userCache,`
`53`		`- _blockRecursion=!getSolverParams(dfg).attemptGradients,`
	`53`	`+ # Block recursion if NoSolverParams or if set to not attempt gradients.`
	`54`	`+ _blockRecursion=`
	`55`	`+ getSolverParams(dfg) isa NoSolverParams \|\|`
	`56`	`+ !getSolverParams(dfg).attemptGradients,`
`54`	`57`	`)`
`55`	`58`	`#`
`56`	`59`