Skip to content

Commit 8c9b8e5

Browse files
committed
Fix parametric solveUp svector
1 parent fb11a0d commit 8c9b8e5

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

src/manifolds/services/ManifoldSampling.jl

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,12 @@ end
2424

2525
# Sampling Distributions
2626
# assumes M is a group and will break for Riemannian, but leaving that enhancement as TODO
27-
function sampleTangent(M::AbstractManifold, z::Distribution, p = getPointIdentity(M), basis::AbstractBasis = DefaultOrthogonalBasis())
27+
function sampleTangent(
28+
M::AbstractManifold,
29+
z::Distribution,
30+
p = getPointIdentity(M),
31+
basis::AbstractBasis = DefaultOrthogonalBasis()
32+
)
2833
return get_vector(M, p, rand(z), basis)
2934
end
3035

src/manifolds/services/ManifoldsExtentions.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ end
105105

106106
# fallback
107107
function getPointIdentity(G::GroupManifold, ::Type{T} = Float64) where {T <: Real}
108-
return error("getPointIdentity not implemented on G")
108+
return error("getPointIdentity not implemented on $G")
109109
end
110110

111111
function getPointIdentity(

src/parametric/services/ParametricCSMFunctions.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ function solveUp_ParametricStateMachine(csmc::CliqStateMachineContainer)
3838
vnd = getSolverData(getVariable(csmc.cliqSubFg, v), :parametric)
3939
# fill in the variable node data value
4040
logCSM(csmc, "$(csmc.cliq.id) up: updating $v : $val")
41-
vnd.val[1] .= val.val
41+
vnd.val[1] = val.val
4242
#calculate and fill in covariance
4343
#TODO rather broadcast than make new memory
4444
vnd.bw = val.cov
@@ -146,7 +146,7 @@ function solveDown_ParametricStateMachine(csmc::CliqStateMachineContainer)
146146
logCSM(csmc, "$(csmc.cliq.id) down: updating $v : $val"; loglevel = Logging.Info)
147147
vnd = getSolverData(getVariable(csmc.cliqSubFg, v), :parametric)
148148
#Update subfg variables
149-
vnd.val[1] .= val.val
149+
vnd.val[1] = val.val
150150
vnd.bw .= val.cov
151151
end
152152
else

0 commit comments

Comments
 (0)