Skip to content

Commit 90d9465

Browse files
committed
add more docs
1 parent aa3384c commit 90d9465

File tree

2 files changed

+13
-5
lines changed

2 files changed

+13
-5
lines changed

src/ParametricUtils.jl

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,18 @@ end
3939
"""
4040
$SIGNATURES
4141
42-
Returns the parametric measurement for a factor as a tuple (measurement, inverse covariance) for parametric inference (assumign Gaussian).
43-
Defaults to find the parametric measurement at field `Z` followed by `z`.
42+
Returns the parametric measurement for a factor as a tuple (measurement, inverse covariance) for parametric inference (assuming Gaussian).
43+
Defaults to find the parametric measurement at field `Zij`, `Z`, or `z`.
4444
4545
Notes
4646
- Users should overload this method should their factor not default to `.Z<:ParametricType` or `.z<:ParametricType`
47-
- See https://github.com/JuliaRobotics/RoME.jl/issues/465
47+
- First design choice was to restrict this function to returning coordinates
48+
- See https://github.com/JuliaRobotics/RoME.jl/issues/465
49+
- Pay attention to which tangent space point is used for converting points on a manifold to coordinates,
50+
- Originally written just for Lie Groups to support legacy, but future needs may well alter the design.
51+
- Original design driven by parametric solve and dead reckon tethering.
52+
53+
See also: [`accumulateFactorMeans`](@ref), [`solveFactorParameteric`](@ref)
4854
"""
4955
function getMeasurementParametric end
5056

src/SolverUtilities.jl

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,16 @@ function fastnorm(u)
99
@fastmath @inbounds return sqrt(s)
1010
end
1111

12+
1213
"""
1314
$SIGNATURES
1415
1516
Helper function for IIF.getSample, to generate a vector of points regardless of the Manifold and probability density function used.
1617
17-
Related
18+
DevNotes:
19+
- FIXME deprecate to `sample`, see JuliaRobotics/RoME.jl#465
1820
19-
[`getSample`](@ref)
21+
See also: [`getSample`](@ref), [`rand`]
2022
"""
2123
randToPoints(distr::SamplableBelief, N::Int=1) = [rand(distr,1)[:] for i in 1:N]
2224
randToPoints(distr::ManifoldKernelDensity, N::Int=1) = rand(distr,N)

0 commit comments

Comments
 (0)