Skip to content

Commit 9d6c581

Browse files
committed
drop warning
1 parent 3b44e29 commit 9d6c581

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/entities/CalcFactor.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,11 +120,11 @@ _nvars(::CalcFactorResidual{FT, C, D, L, P, MEAS, N}) where {FT, C, D, L, P, MEA
120120
# _typeof_meas(::CalcFactorManopt{FT, C, D, L, MEAS, N}) where {FT, C, D, L, MEAS, N} = MEAS
121121
DFG.getDimension(::CalcFactorResidual{FT, C, D, L, P, MEAS, N}) where {FT, C, D, L, P, MEAS, N} = D
122122

123-
# FIXME HACK workaround for issue #1781
123+
# workaround for issue #1781
124124
import Base: getproperty
125125
function Base.getproperty(cf::CalcFactorResidual, f::Symbol)
126126
if f === :manifold
127-
@warn "CalcFactorResidual.manifold workaround FIXME" maxlog=10
127+
# assumes constant propagation to avoid allocations in residual functions getManifold(factor)
128128
getManifold(cf.factor)
129129
else
130130
getfield(cf, f)

0 commit comments

Comments
 (0)